Skip to content

Commit d463b74

Browse files
committed
!fixup! Remove more test assumptions that branding == target TFM
1 parent fd5a807 commit d463b74

File tree

5 files changed

+10
-3
lines changed

5 files changed

+10
-3
lines changed

src/Framework/test/Microsoft.AspNetCore.App.UnitTests.csproj

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,10 @@
1717
<_Parameter1>SharedFxVersion</_Parameter1>
1818
<_Parameter2>$(SharedFxVersion)</_Parameter2>
1919
</AssemblyAttribute>
20+
<AssemblyAttribute Include="Microsoft.AspNetCore.TestData">
21+
<_Parameter1>DefaultNetCoreTargetFramework</_Parameter1>
22+
<_Parameter2>$(DefaultNetCoreTargetFramework)</_Parameter2>
23+
</AssemblyAttribute>
2024
<AssemblyAttribute Include="Microsoft.AspNetCore.TestData">
2125
<_Parameter1>TargetRuntimeIdentifier</_Parameter1>
2226
<_Parameter2>$(TargetRuntimeIdentifier)</_Parameter2>

src/Framework/test/SharedFxTests.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ public class SharedFxTests
2121
public SharedFxTests(ITestOutputHelper output)
2222
{
2323
_output = output;
24-
_expectedTfm = "net" + TestData.GetSharedFxVersion().Substring(0, 3);
24+
_expectedTfm = TestData.GetDefaultNetCoreTargetFramework();
2525
_expectedRid = TestData.GetSharedFxRuntimeIdentifier();
2626
_sharedFxRoot = string.IsNullOrEmpty(Environment.GetEnvironmentVariable("ASPNET_RUNTIME_PATH"))
2727
? Path.Combine(TestData.GetTestDataValue("SharedFrameworkLayoutRoot"), "shared", "Microsoft.AspNetCore.App", TestData.GetTestDataValue("RuntimePackageVersion"))
@@ -102,7 +102,7 @@ public void ItContainsValidDepsJson()
102102
{
103103
var depsFilePath = Path.Combine(_sharedFxRoot, "Microsoft.AspNetCore.App.deps.json");
104104

105-
var target = $".NETCoreApp,Version=v{TestData.GetSharedFxVersion().Substring(0, 3)}/{_expectedRid}";
105+
var target = $".NETCoreApp,Version=v{_expectedTfm.Substring(3)}/{_expectedRid}";
106106
var ridPackageId = $"Microsoft.AspNetCore.App.Runtime.{_expectedRid}";
107107
var libraryId = $"{ridPackageId}/{TestData.GetTestDataValue("RuntimePackageVersion")}";
108108

src/Framework/test/TargetingPackTests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ public TargetingPackTests(ITestOutputHelper output)
2727
{
2828
_output = output;
2929
_expectedRid = TestData.GetSharedFxRuntimeIdentifier();
30-
_targetingPackTfm = "net" + TestData.GetSharedFxVersion().Substring(0, 3);
30+
_targetingPackTfm = TestData.GetDefaultNetCoreTargetFramework();
3131
_targetingPackRoot = string.IsNullOrEmpty(Environment.GetEnvironmentVariable("helix"))
3232
? Path.Combine(TestData.GetTestDataValue("TargetingPackLayoutRoot"), "packs", "Microsoft.AspNetCore.App.Ref", TestData.GetTestDataValue("TargetingPackVersion"))
3333
: Path.Combine(Environment.GetEnvironmentVariable("HELIX_WORKITEM_ROOT"), "Microsoft.AspNetCore.App.Ref");

src/Framework/test/TestData.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -290,6 +290,8 @@ static TestData()
290290

291291
public static string GetSharedFxVersion() => GetTestDataValue("SharedFxVersion");
292292

293+
public static string GetDefaultNetCoreTargetFramework() => GetTestDataValue("DefaultNetCoreTargetFramework");
294+
293295
public static string GetMicrosoftNETCoreAppPackageVersion() => GetTestDataValue("MicrosoftNETCoreAppRuntimeVersion");
294296

295297
public static string GetReferencePackSharedFxVersion() => GetTestDataValue("ReferencePackSharedFxVersion");

src/Grpc/test/InteropTests/InteropTests.csproj

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
<PropertyGroup>
44
<ContainsFunctionalTestAssets>true</ContainsFunctionalTestAssets>
55
<TargetFramework>$(DefaultNetCoreTargetFramework)</TargetFramework>
6+
<TestDependsOnAspNetRuntime>true</TestDependsOnAspNetRuntime>
67
</PropertyGroup>
78

89
<ItemGroup>

0 commit comments

Comments
 (0)