Skip to content

Commit c6b39de

Browse files
committed
Addressed all the feedback
1 parent f659457 commit c6b39de

File tree

5 files changed

+6
-66
lines changed

5 files changed

+6
-66
lines changed

src/Shared/BrowserTesting/src/BrowserManager.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ public Task<IBrowserContext> GetBrowserInstance(string browserInstance, ContextI
8080
}
8181

8282
return AttachContextInfo(
83-
browser.NewContextAsync(contextInfo.Contextualize(_browserManagerConfiguration.GetContextOptions(browserInstance))),
83+
browser.NewContextAsync(contextInfo.ConfigureUniqueHarPath(_browserManagerConfiguration.GetContextOptions(browserInstance))),
8484
contextInfo);
8585
}
8686

@@ -95,7 +95,7 @@ public Task<IBrowserContext> GetBrowserInstance(string browserInstance, string c
9595
}
9696

9797
return AttachContextInfo(
98-
browser.NewContextAsync(contextInfo.Contextualize(_browserManagerConfiguration.GetContextOptions(browserInstance, contextName))),
98+
browser.NewContextAsync(contextInfo.ConfigureUniqueHarPath(_browserManagerConfiguration.GetContextOptions(browserInstance, contextName))),
9999
contextInfo);
100100
}
101101

@@ -110,7 +110,7 @@ public Task<IBrowserContext> GetBrowserInstance(string browserInstance, string c
110110
}
111111

112112
return AttachContextInfo(
113-
browser.NewContextAsync(contextInfo.Contextualize(_browserManagerConfiguration.GetContextOptions(browserInstance, contextName, options))),
113+
browser.NewContextAsync(contextInfo.ConfigureUniqueHarPath(_browserManagerConfiguration.GetContextOptions(browserInstance, contextName, options))),
114114
contextInfo);
115115
}
116116

src/Shared/BrowserTesting/src/ContextInformation.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ private void AttachToPage(object sender, PageEventArgs args)
3737
Pages.Add(args.Page, new PageInformation(args.Page, logger));
3838
}
3939

40-
internal BrowserContextOptions Contextualize(BrowserContextOptions browserContextOptions)
40+
internal BrowserContextOptions ConfigureUniqueHarPath(BrowserContextOptions browserContextOptions)
4141
{
4242
if (browserContextOptions?.RecordHar?.Path != null)
4343
{

src/Shared/BrowserTesting/src/Microsoft.AspNetCore.BrowserTesting.csproj

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,14 +3,13 @@
33
<PropertyGroup>
44
<TargetFramework>$(DefaultNetCoreTargetFramework)</TargetFramework>
55
<PackageTags>aspnetcore;testing</PackageTags>
6-
<DisableFastUpToDateCheck>true</DisableFastUpToDateCheck>
6+
<IsShippingPackage>false</IsShippingPackage>
7+
<AddPublicApiAnalyzers>false</AddPublicApiAnalyzers>
78
</PropertyGroup>
89

910
<ItemGroup>
1011
<Reference Include="PlaywrightSharp" Condition="'$(TargetOsName)' != 'linux-musl'" />
1112
<Reference Include="PlaywrightSharp" ExcludeAssets="build" Condition="'$(TargetOsName)' == 'linux-musl'" />
12-
<Reference Include="xunit.abstractions" />
13-
<Reference Include="xunit.extensibility.core" />
1413
</ItemGroup>
1514

1615
</Project>

src/Shared/BrowserTesting/src/PublicAPI.Shipped.txt

Lines changed: 0 additions & 1 deletion
This file was deleted.

src/Shared/BrowserTesting/src/PublicAPI.Unshipped.txt

Lines changed: 0 additions & 58 deletions
This file was deleted.

0 commit comments

Comments
 (0)