PR feedback

JamesNK · JamesNK · commit bf19e03feaee · 2022-12-17T11:35:53.000+08:00
diff --git a/src/Shared/EndpointMetadataPopulator.cs b/src/Shared/EndpointMetadataPopulator.cs
@@ -11,8 +11,8 @@
 
 namespace Microsoft.AspNetCore.Http;
 
-[UnconditionalSuppressMessage("Trimmer", "IL2060", Justification = "Trimmer warnings are presented in RequestDelegateFactory.")]
-[UnconditionalSuppressMessage("AOT", "IL3050", Justification = "AOT warnings are presented in RequestDelegateFactory.")]
+[RequiresUnreferencedCode("This API performs reflection on types that can't be statically analyzed.")]
+[RequiresDynamicCode("This API performs reflection on types that can't be statically analyzed.")]
 internal static class EndpointMetadataPopulator
 {
     private static readonly MethodInfo PopulateMetadataForParameterMethod = typeof(EndpointMetadataPopulator).GetMethod(nameof(PopulateMetadataForParameter), BindingFlags.NonPublic | BindingFlags.Static)!;

Original file line number	Diff line number	Diff line change
`@@ -11,8 +11,8 @@`
`11`	`11`
`12`	`12`	`namespace Microsoft.AspNetCore.Http;`
`13`	`13`
`14`		`-[UnconditionalSuppressMessage("Trimmer", "IL2060", Justification = "Trimmer warnings are presented in RequestDelegateFactory.")]`
`15`		`-[UnconditionalSuppressMessage("AOT", "IL3050", Justification = "AOT warnings are presented in RequestDelegateFactory.")]`
	`14`	`+[RequiresUnreferencedCode("This API performs reflection on types that can't be statically analyzed.")]`
	`15`	`+[RequiresDynamicCode("This API performs reflection on types that can't be statically analyzed.")]`
`16`	`16`	`internal static class EndpointMetadataPopulator`
`17`	`17`	`{`
`18`	`18`	`private static readonly MethodInfo PopulateMetadataForParameterMethod = typeof(EndpointMetadataPopulator).GetMethod(nameof(PopulateMetadataForParameter), BindingFlags.NonPublic \| BindingFlags.Static)!;`