Address feedback from peer review

Author: captainsafia

src/Http/Http.Extensions/gen/RequestDelegateGenerator.cs

@@ -60,21 +60,21 @@ public void Initialize(IncrementalGeneratorInitializationContext context)
             {
                 using var stringWriter = new StringWriter(CultureInfo.InvariantCulture);
                 using var codeWriter = new CodeWriter(stringWriter, baseIndent: 2);
-                codeWriter.WriteLine($$"""[global::System.Runtime.CompilerServices.InterceptsLocation(@"{{endpoint!.Location.File}}", {{endpoint.Location.LineNumber}}, {{endpoint.Location.CharaceterNumber + 1}})]""");
-                codeWriter.WriteLine($"internal static global::Microsoft.AspNetCore.Builder.RouteHandlerBuilder {endpoint!.HttpMethod}_{endpoint.Location.LineNumber}(");
+                codeWriter.WriteLine($$"""[InterceptsLocation(@"{{endpoint.Location.File}}", {{endpoint.Location.LineNumber}}, {{endpoint.Location.CharacterNumber + 1}})]""");
+                codeWriter.WriteLine($"internal static RouteHandlerBuilder {endpoint.HttpMethod}_{endpoint.Location.LineNumber}(");
                 codeWriter.Indent++;
-                codeWriter.WriteLine("this global::Microsoft.AspNetCore.Routing.IEndpointRouteBuilder endpoints,");
+                codeWriter.WriteLine("this IEndpointRouteBuilder endpoints,");
                 // MapFallback overloads that only take a delegate do not need a pattern argument
                 if (endpoint.HttpMethod != "MapFallback" || endpoint.Operation.Arguments.Length != 2)
                 {
-                    codeWriter.WriteLine(@"[global::System.Diagnostics.CodeAnalysis.StringSyntax(""Route"")] string pattern,");
+                    codeWriter.WriteLine(@"[StringSyntax(""Route"")] string pattern,");
                 }
                 // MapMethods overloads define an additional `httpMethods` parameter
                 if (endpoint.HttpMethod == "MapMethods")
                 {
-                    codeWriter.WriteLine("global::System.Collections.Generic.IEnumerable<string> httpMethods,");
+                    codeWriter.WriteLine("IEnumerable<string> httpMethods,");
                 }
-                codeWriter.WriteLine($"global::System.Delegate handler)");
+                codeWriter.WriteLine("Delegate handler)");
                 codeWriter.Indent--;
                 codeWriter.StartBlock();
                 codeWriter.WriteLine("MetadataPopulator populateMetadata = (methodInfo, options) =>");
@@ -135,7 +135,7 @@ public void Initialize(IncrementalGeneratorInitializationContext context)
                 codeWriter.WriteLine("return new RequestDelegateResult(targetDelegate, metadata);");
                 codeWriter.EndBlockWithSemicolon();
 
-                codeWriter.WriteLine("return global::Microsoft.AspNetCore.Http.Generated.GeneratedRouteBuilderExtensionsCore.MapCore(");
+                codeWriter.WriteLine("return GeneratedRouteBuilderExtensionsCore.MapCore(");
                 codeWriter.Indent++;
                 codeWriter.WriteLine("endpoints,");
                 // For `MapFallback` overloads that only take a delegate, provide the assumed default
@@ -149,7 +149,7 @@ public void Initialize(IncrementalGeneratorInitializationContext context)
                     codeWriter.WriteLine($"{SymbolDisplay.FormatLiteral("{*path:nonfile}", true)},");
                 }
                 codeWriter.WriteLine("handler,");
-                codeWriter.WriteLine($"{endpoint!.EmitVerb()},");
+                codeWriter.WriteLine($"{endpoint.EmitVerb()},");
                 codeWriter.WriteLine("populateMetadata,");
                 codeWriter.WriteLine($"createRequestDelegate);");
                 codeWriter.Indent--;

src/Http/Http.Extensions/gen/RequestDelegateGeneratorSources.cs

@@ -542,6 +542,7 @@ namespace Microsoft.AspNetCore.Http.Generated
     using System.Globalization;
     using System.Linq;
     using System.Reflection;
+    using System.Runtime.CompilerServices;
     using System.Text.Json;
     using System.Text.Json.Serialization.Metadata;
     using System.Threading.Tasks;
@@ -564,11 +565,11 @@ namespace Microsoft.AspNetCore.Http.Generated
     {{GeneratedCodeAttribute}}
     file static class GeneratedRouteBuilderExtensionsCore
     {
-        private static readonly string[] GetVerb = new[] { global::Microsoft.AspNetCore.Http.HttpMethods.Get };
-        private static readonly string[] PostVerb = new[] { global::Microsoft.AspNetCore.Http.HttpMethods.Post };
-        private static readonly string[] PutVerb = new[]  { global::Microsoft.AspNetCore.Http.HttpMethods.Put };
-        private static readonly string[] DeleteVerb = new[] { global::Microsoft.AspNetCore.Http.HttpMethods.Delete };
-        private static readonly string[] PatchVerb = new[] { global::Microsoft.AspNetCore.Http.HttpMethods.Patch };
+        private static readonly string[] GetVerb = new[] { Microsoft.AspNetCore.Http.HttpMethods.Get };
+        private static readonly string[] PostVerb = new[] { Microsoft.AspNetCore.Http.HttpMethods.Post };
+        private static readonly string[] PutVerb = new[]  { Microsoft.AspNetCore.Http.HttpMethods.Put };
+        private static readonly string[] DeleteVerb = new[] { Microsoft.AspNetCore.Http.HttpMethods.Delete };
+        private static readonly string[] PatchVerb = new[] { Microsoft.AspNetCore.Http.HttpMethods.Patch };
 
         {{endpoints}}
 

src/Http/Http.Extensions/gen/StaticRouteHandler/Emitters/EmitterConstants.cs

@@ -7,13 +7,13 @@ namespace Microsoft.AspNetCore.Http.RequestDelegateGenerator.StaticRouteHandler.
 internal static class EmitterConstants
 {
     public static SymbolDisplayFormat DisplayFormat => new SymbolDisplayFormat(
-        globalNamespaceStyle: SymbolDisplayGlobalNamespaceStyle.Included,
+        globalNamespaceStyle: SymbolDisplayGlobalNamespaceStyle.Omitted,
         genericsOptions: SymbolDisplayGenericsOptions.IncludeTypeParameters,
         typeQualificationStyle: SymbolDisplayTypeQualificationStyle.NameAndContainingTypesAndNamespaces,
         miscellaneousOptions: SymbolDisplayMiscellaneousOptions.IncludeNullableReferenceTypeModifier);
 
     public static SymbolDisplayFormat DisplayFormatWithoutNullability => new SymbolDisplayFormat(
-        globalNamespaceStyle: SymbolDisplayGlobalNamespaceStyle.Included,
+        globalNamespaceStyle: SymbolDisplayGlobalNamespaceStyle.Omitted,
         genericsOptions: SymbolDisplayGenericsOptions.IncludeTypeParameters,
         typeQualificationStyle: SymbolDisplayTypeQualificationStyle.NameAndContainingTypesAndNamespaces);
 }

src/Http/Http.Extensions/gen/StaticRouteHandler/Model/Endpoint.cs

@@ -90,13 +90,12 @@ public Endpoint(IInvocationOperation operation, WellKnownTypes wellKnownTypes, S
     public string HttpMethod { get; }
     public bool IsAwaitable { get; set; }
     public bool NeedsParameterArray { get; }
-    public string? RoutePattern { get; }
     public EmitterContext EmitterContext { get; }
     public EndpointResponse? Response { get; }
     public EndpointParameter[] Parameters { get; } = Array.Empty<EndpointParameter>();
     public List<Diagnostic> Diagnostics { get; } = new List<Diagnostic>();
 
-    public (string File, int LineNumber, int CharaceterNumber) Location { get; }
+    public (string File, int LineNumber, int CharacterNumber) Location { get; }
     public IInvocationOperation Operation { get; }
 
     public override bool Equals(object o) =>