Address non-test related feedback

Author: captainsafia

src/Http/Routing/src/Builder/RoutingEndpointConventionBuilderExtensions.cs

@@ -121,7 +121,9 @@ public static TBuilder WithMetadata<TBuilder>(this TBuilder builder, params obje
 
         /// <summary>
         /// Sets the <see cref="EndpointNameAttribute"/> for all endpoints produced
-        /// on the target <see cref="IEndpointConventionBuilder"/>.
+        /// on the target <see cref="IEndpointConventionBuilder"/> given the <paramref name="endpointName" />.
+        /// The <see cref="IEndpointNameMetadata" /> on the endpoint is used for link generation and
+        /// is treated as the operation ID in the given endpoint's OpenAPI specification.
         /// </summary>
         /// <param name="builder">The <see cref="IEndpointConventionBuilder"/>.</param>
         /// <param name="endpointName">The endpoint name.</param>
@@ -134,7 +136,9 @@ public static TBuilder WithName<TBuilder>(this TBuilder builder, string endpoint
 
         /// <summary>
         /// Sets the <see cref="EndpointGroupNameAttribute"/> for all endpoints produced
-        /// on the target <see cref="IEndpointConventionBuilder"/>.
+        /// on the target <see cref="IEndpointConventionBuilder"/> given the <paramref name="endpointGroupName" />.
+        /// The <see cref="IEndpointGroupNameMetadata" /> on the endpoint is used to set the endpoint's
+        /// GroupName in the OpenAPI specification.
         /// </summary>
         /// <param name="builder">The <see cref="IEndpointConventionBuilder"/>.</param>
         /// <param name="endpointGroupName">The endpoint group name.</param>

src/Http/Routing/src/EndpointGroupNameAttribute.cs

@@ -3,7 +3,7 @@
 
 using System;
 using Microsoft.AspNetCore.Http;
- 
+
  namespace Microsoft.AspNetCore.Routing
  {
     /// <summary>
@@ -13,7 +13,7 @@ namespace Microsoft.AspNetCore.Routing
     public sealed class EndpointGroupNameAttribute : Attribute, IEndpointGroupNameMetadata
     {
         /// <summary>
-        /// Initializes an instance of the EndpointGroupNameAttribute.
+        /// Initializes an instance of the <see cref="EndpointGroupNameAttribute"/>.
         /// </summary>
         /// <param name="endpointGroupName">The endpoint group name.</param>
         public EndpointGroupNameAttribute(string endpointGroupName)
@@ -22,7 +22,7 @@ public EndpointGroupNameAttribute(string endpointGroupName)
             {
                 throw new ArgumentNullException(nameof(endpointGroupName));
             }
-    
+
             EndpointGroupName = endpointGroupName;
         }
 

src/Mvc/Mvc.ApiExplorer/src/EndpointMetadataApiDescriptionProvider.cs

@@ -53,8 +53,7 @@ public void OnProvidersExecuting(ApiDescriptionProviderContext context)
                 if (endpoint is RouteEndpoint routeEndpoint &&
                     routeEndpoint.Metadata.GetMetadata<MethodInfo>() is { } methodInfo &&
                     routeEndpoint.Metadata.GetMetadata<IHttpMethodMetadata>() is { } httpMethodMetadata &&
-                    (routeEndpoint.Metadata.GetMetadata<IExcludeFromDescriptionMetadata>() == null ||
-                    routeEndpoint.Metadata.GetMetadata<IExcludeFromDescriptionMetadata>() is { ExcludeFromDescription: false} ))
+                    routeEndpoint.Metadata.GetMetadata<IExcludeFromDescriptionMetadata>() is null or { ExcludeFromDescription: false})
                 {
                     // REVIEW: Should we add an ApiDescription for endpoints without IHttpMethodMetadata? Swagger doesn't handle
                     // a null HttpMethod even though it's nullable on ApiDescription, so we'd need to define "default" HTTP methods.

src/Mvc/Mvc.Core/src/ProducesResponseTypeAttribute.cs

@@ -5,6 +5,7 @@
 using Microsoft.AspNetCore.Mvc.ApiExplorer;
 using Microsoft.AspNetCore.Mvc.Formatters;
 using Microsoft.Net.Http.Headers;
+using Resources = Microsoft.AspNetCore.Mvc.Core.Resources;
 
 namespace Microsoft.AspNetCore.Mvc
 {
@@ -102,7 +103,7 @@ void IApiResponseMetadataProvider.SetContentTypes(MediaTypeCollection contentTyp
 
         private static MediaTypeCollection GetContentTypes(string contentType, string[] additionalContentTypes)
         {
-            List<string> completeContentTypes = new(additionalContentTypes.Length + 1);
+            var completeContentTypes = new List<string>(additionalContentTypes.Length + 1);
             completeContentTypes.Add(contentType);
             completeContentTypes.AddRange(additionalContentTypes);
             MediaTypeCollection contentTypes = new();
@@ -111,7 +112,7 @@ private static MediaTypeCollection GetContentTypes(string contentType, string[]
                 var mediaType = new MediaType(type);
                 if (mediaType.HasWildcard)
                 {
-                    throw new InvalidOperationException("Content types with wildcards are not supported.");
+                    throw new InvalidOperationException(Resources.FormatGetContentTypes_WildcardsNotSupported(type));
                 }
 
                 contentTypes.Add(type);

src/Mvc/Mvc.Core/src/Resources.resx

@@ -1,17 +1,17 @@
 <?xml version="1.0" encoding="utf-8"?>
 <root>
-  <!-- 
-    Microsoft ResX Schema 
-    
+  <!--
+    Microsoft ResX Schema
+
     Version 2.0
-    
-    The primary goals of this format is to allow a simple XML format 
-    that is mostly human readable. The generation and parsing of the 
-    various data types are done through the TypeConverter classes 
+
+    The primary goals of this format is to allow a simple XML format
+    that is mostly human readable. The generation and parsing of the
+    various data types are done through the TypeConverter classes
     associated with the data types.
-    
+
     Example:
-    
+
     ... ado.net/XML headers & schema ...
     <resheader name="resmimetype">text/microsoft-resx</resheader>
     <resheader name="version">2.0</resheader>
@@ -26,36 +26,36 @@
         <value>[base64 mime encoded string representing a byte array form of the .NET Framework object]</value>
         <comment>This is a comment</comment>
     </data>
-                
-    There are any number of "resheader" rows that contain simple 
+
+    There are any number of "resheader" rows that contain simple
     name/value pairs.
-    
-    Each data row contains a name, and value. The row also contains a 
-    type or mimetype. Type corresponds to a .NET class that support 
-    text/value conversion through the TypeConverter architecture. 
-    Classes that don't support this are serialized and stored with the 
+
+    Each data row contains a name, and value. The row also contains a
+    type or mimetype. Type corresponds to a .NET class that support
+    text/value conversion through the TypeConverter architecture.
+    Classes that don't support this are serialized and stored with the
     mimetype set.
-    
-    The mimetype is used for serialized objects, and tells the 
-    ResXResourceReader how to depersist the object. This is currently not 
+
+    The mimetype is used for serialized objects, and tells the
+    ResXResourceReader how to depersist the object. This is currently not
     extensible. For a given mimetype the value must be set accordingly:
-    
-    Note - application/x-microsoft.net.object.binary.base64 is the format 
-    that the ResXResourceWriter will generate, however the reader can 
+
+    Note - application/x-microsoft.net.object.binary.base64 is the format
+    that the ResXResourceWriter will generate, however the reader can
     read any of the formats listed below.
-    
+
     mimetype: application/x-microsoft.net.object.binary.base64
-    value   : The object must be serialized with 
+    value   : The object must be serialized with
             : System.Runtime.Serialization.Formatters.Binary.BinaryFormatter
             : and then encoded with base64 encoding.
-    
+
     mimetype: application/x-microsoft.net.object.soap.base64
-    value   : The object must be serialized with 
+    value   : The object must be serialized with
             : System.Runtime.Serialization.Formatters.Soap.SoapFormatter
             : and then encoded with base64 encoding.
 
     mimetype: application/x-microsoft.net.object.bytearray.base64
-    value   : The object must be serialized into a byte array 
+    value   : The object must be serialized into a byte array
             : using a System.ComponentModel.TypeConverter
             : and then encoded with base64 encoding.
     -->
@@ -510,4 +510,7 @@
   <data name="TryUpdateModel_RecordTypeNotSupported" xml:space="preserve">
     <value>{0} cannot update a record type model. If a '{1}' must be updated, include it in an object type.</value>
   </data>
+  <data name="GetContentTypes_WildcardsNotSupported" xml:space="preserve">
+    <value>Could not parse '{0}'. Content types with wildcards are not supported.</value>
+  </data>
 </root>