Blazor flaky test sanctuary (#26286)

Author: HaoK

src/Components/test/E2ETest/ServerExecutionTests/ServerGlobalizationTest.cs

@@ -34,7 +34,6 @@ protected override void InitializeAsyncCore()
             Browser.Exists(By.Id("culture-selector"));
         }
 
-        [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/24692")]
         [Theory]
         [InlineData("en-US")]
         [InlineData("fr-FR")]

src/Components/test/E2ETest/Tests/BindTest.cs

@@ -389,7 +389,6 @@ public void CanBindTextboxShort()
         }
 
         [Fact]
-        [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/23826")]
         public void CanBindTextboxNullableShort()
         {
             var target = Browser.FindElement(By.Id("textbox-nullable-short"));
@@ -512,7 +511,6 @@ public void CanBindTextboxDouble()
         }
 
         [Fact]
-        [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/23596")]
         public void CanBindTextboxNullableDouble()
         {
             var target = Browser.FindElement(By.Id("textbox-nullable-double"));
@@ -612,7 +610,6 @@ public void CanBindTextboxNullableDecimal()
         // This tests what happens you put invalid (unconvertable) input in. This is separate from the
         // other tests because it requires type="text" - the other tests use type="number"
         [Fact]
-        [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/24756")]
         public void CanBindTextbox_Decimal_InvalidInput()
         {
             var target = Browser.FindElement(By.Id("textbox-decimal-invalid"));

src/Components/test/E2ETest/Tests/ErrorNotificationTest.cs

@@ -34,7 +34,6 @@ protected override void InitializeAsyncCore()
         }
 
         [Fact]
-        [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/23643")]
         public void ShowsErrorNotification_OnError_Dismiss()
         {
             var errorUi = Browser.FindElement(By.Id("blazor-error-ui"));
@@ -52,7 +51,6 @@ public void ShowsErrorNotification_OnError_Dismiss()
         }
 
         [Fact]
-        [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/23596")]
         public void ShowsErrorNotification_OnError_Reload()
         {
             var causeErrorButton = Browser.Exists(By.Id("throw-simple-exception"));

src/Components/test/E2ETest/Tests/EventCallbackTest.cs

@@ -30,7 +30,6 @@ protected override void InitializeAsyncCore()
         }
 
         [Theory]
-        [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/23643")]
         [InlineData("capturing_lambda")]
         [InlineData("unbound_lambda")]
         [InlineData("unbound_lambda_nested")]

src/Components/test/E2ETest/Tests/GlobalizationTest.cs

@@ -87,7 +87,6 @@ public virtual void CanSetCultureAndParseCultureSensitiveNumbersAndDates(string
         // We need to do step 4 to make sure that the value we're entering can "stick" in the form field.
         // We can't use ".Text" because DOM reasons :(
         [Theory]
-        [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/23643")]
         [InlineData("en-US")]
         [InlineData("fr-FR")]
         public void CanSetCultureAndParseCultureInvariantNumbersAndDatesWithInputFields(string culture)

src/Components/test/E2ETest/Tests/KeyTest.cs

@@ -92,7 +92,6 @@ public void CanInsertUnkeyed()
         }
 
         [Fact]
-        [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/24190")]
         public void CanDeleteUnkeyed()
         {
             PerformTest(
@@ -112,7 +111,6 @@ public void CanDeleteUnkeyed()
         }
 
         [Fact]
-        [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/24190")]
         public void CanReorder()
         {
             PerformTest(

src/Components/test/E2ETest/Tests/WebAssemblyConfigurationHostedTest.cs

@@ -34,7 +34,6 @@ protected override void InitializeAsyncCore()
         }
 
         [Fact]
-        [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/25929")]
         public void WebAssemblyConfiguration_Works()
         {
             // Verify values from the default 'appsettings.json' are read.

src/Shared/E2ETesting/BrowserFixture.cs

@@ -70,6 +70,7 @@ public async Task DisposeAsync()
             var browsers = await Task.WhenAll(_browsers.Values);
             foreach (var (browser, log) in browsers)
             {
+                browser?.Quit();
                 browser?.Dispose();
             }
 
@@ -320,7 +321,9 @@ private string UserProfileDirectory(string context)
                         capabilities,
                         TimeSpan.FromSeconds(60).Add(TimeSpan.FromSeconds(attempt * 60)));
 
-                    driver.Manage().Timeouts().ImplicitWait = TimeSpan.FromSeconds(1);
+                    // Make sure implicit waits are disabled as they don't mix well with explicit waiting
+                    // see https://www.selenium.dev/documentation/en/webdriver/waits/#implicit-wait
+                    driver.Manage().Timeouts().ImplicitWait = TimeSpan.Zero;
                     var logs = new RemoteLogs(driver);
 
                     return (driver, logs);