Fix RequestDelegate being chosen over Delegate in overload resolution

Attempt to resolve the issue where the RequestDelegate overload is
incorrectly preferred over the Delegate overload by using the new
OverloadResolutionPriority attribute.

Author: bjornen77

src/Http/Routing/src/Builder/EndpointRouteBuilderExtensions.cs

@@ -2,6 +2,7 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 
 using System.Diagnostics.CodeAnalysis;
+using System.Runtime.CompilerServices;
 using Microsoft.AspNetCore.Http;
 using Microsoft.AspNetCore.Routing;
 using Microsoft.AspNetCore.Routing.Patterns;
@@ -227,6 +228,7 @@ static RequestDelegateResult CreateHandlerRequestDelegate(Delegate handler, Requ
     /// <returns>A <see cref="RouteHandlerBuilder"/> that can be used to further customize the endpoint.</returns>
     [RequiresUnreferencedCode(MapEndpointUnreferencedCodeWarning)]
     [RequiresDynamicCode(MapEndpointDynamicCodeWarning)]
+    [OverloadResolutionPriority(1)]
     public static RouteHandlerBuilder MapGet(
         this IEndpointRouteBuilder endpoints,
         [StringSyntax("Route")] string pattern,
@@ -245,6 +247,7 @@ public static RouteHandlerBuilder MapGet(
     /// <returns>A <see cref="RouteHandlerBuilder"/> that can be used to further customize the endpoint.</returns>
     [RequiresUnreferencedCode(MapEndpointUnreferencedCodeWarning)]
     [RequiresDynamicCode(MapEndpointDynamicCodeWarning)]
+    [OverloadResolutionPriority(1)]
     public static RouteHandlerBuilder MapPost(
         this IEndpointRouteBuilder endpoints,
         [StringSyntax("Route")] string pattern,
@@ -263,6 +266,7 @@ public static RouteHandlerBuilder MapPost(
     /// <returns>A <see cref="RouteHandlerBuilder"/> that can be used to further customize the endpoint.</returns>
     [RequiresUnreferencedCode(MapEndpointUnreferencedCodeWarning)]
     [RequiresDynamicCode(MapEndpointDynamicCodeWarning)]
+    [OverloadResolutionPriority(1)]
     public static RouteHandlerBuilder MapPut(
         this IEndpointRouteBuilder endpoints,
         [StringSyntax("Route")] string pattern,
@@ -281,6 +285,7 @@ public static RouteHandlerBuilder MapPut(
     /// <returns>A <see cref="RouteHandlerBuilder"/> that can be used to further customize the endpoint.</returns>
     [RequiresUnreferencedCode(MapEndpointUnreferencedCodeWarning)]
     [RequiresDynamicCode(MapEndpointDynamicCodeWarning)]
+    [OverloadResolutionPriority(1)]
     public static RouteHandlerBuilder MapDelete(
         this IEndpointRouteBuilder endpoints,
         [StringSyntax("Route")] string pattern,
@@ -299,6 +304,7 @@ public static RouteHandlerBuilder MapDelete(
     /// <returns>A <see cref="RouteHandlerBuilder"/> that can be used to further customize the endpoint.</returns>
     [RequiresUnreferencedCode(MapEndpointUnreferencedCodeWarning)]
     [RequiresDynamicCode(MapEndpointDynamicCodeWarning)]
+    [OverloadResolutionPriority(1)]
     public static RouteHandlerBuilder MapPatch(
         this IEndpointRouteBuilder endpoints,
         [StringSyntax("Route")] string pattern,
@@ -338,6 +344,7 @@ public static RouteHandlerBuilder MapMethods(
     /// <returns>A <see cref="RouteHandlerBuilder"/> that can be used to further customize the endpoint.</returns>
     [RequiresUnreferencedCode(MapEndpointUnreferencedCodeWarning)]
     [RequiresDynamicCode(MapEndpointDynamicCodeWarning)]
+    [OverloadResolutionPriority(1)]
     public static RouteHandlerBuilder Map(
         this IEndpointRouteBuilder endpoints,
         [StringSyntax("Route")] string pattern,
@@ -413,6 +420,7 @@ public static RouteHandlerBuilder MapFallback(this IEndpointRouteBuilder endpoin
     /// </remarks>
     [RequiresUnreferencedCode(MapEndpointUnreferencedCodeWarning)]
     [RequiresDynamicCode(MapEndpointDynamicCodeWarning)]
+    [OverloadResolutionPriority(1)]
     public static RouteHandlerBuilder MapFallback(
         this IEndpointRouteBuilder endpoints,
         [StringSyntax("Route")] string pattern,

src/Http/Routing/src/Builder/FallbackEndpointRouteBuilderExtensions.cs

@@ -4,6 +4,7 @@
 using System.Diagnostics.CodeAnalysis;
 using Microsoft.AspNetCore.Http;
 using Microsoft.AspNetCore.Routing;
+using Microsoft.AspNetCore.Routing.Patterns;
 
 namespace Microsoft.AspNetCore.Builder;
 
@@ -74,7 +75,7 @@ public static IEndpointConventionBuilder MapFallback(
         ArgumentNullException.ThrowIfNull(pattern);
         ArgumentNullException.ThrowIfNull(requestDelegate);
 
-        var conventionBuilder = endpoints.Map(pattern, requestDelegate);
+        var conventionBuilder = endpoints.Map(RoutePatternFactory.Parse(pattern), requestDelegate);
         conventionBuilder.WithDisplayName("Fallback " + pattern);
         conventionBuilder.Add(b => ((RouteEndpointBuilder)b).Order = int.MaxValue);
         conventionBuilder.WithMetadata(FallbackMetadata.Instance);

src/Http/Routing/src/ShortCircuit/RouteShortCircuitEndpointRouteBuilderExtensions.cs

@@ -3,6 +3,7 @@
 
 using Microsoft.AspNetCore.Builder;
 using Microsoft.AspNetCore.Http;
+using Microsoft.AspNetCore.Routing.Patterns;
 
 namespace Microsoft.AspNetCore.Routing;
 
@@ -34,7 +35,7 @@ public static IEndpointConventionBuilder MapShortCircuit(this IEndpointRouteBuil
             {
                 route = $"{routePrefix}/{{**catchall}}";
             }
-            group.Map(route, _shortCircuitDelegate)
+            group.Map(RoutePatternFactory.Parse(route), _shortCircuitDelegate)
                 .ShortCircuit(statusCode)
                 .Add(endpoint =>
                 {