Skip to content

Commit 85fc7cb

Browse files
Apply suggestions from code review
Co-authored-by: Martin Costello <[email protected]>
1 parent a5f07c0 commit 85fc7cb

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

src/Http/Http.Results/src/AcceptedAtRouteResult.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,12 +38,12 @@ public AcceptedAtRouteResult(
3838
}
3939

4040
/// <summary>
41-
/// Gets or sets the name of the route to use for generating the URL.
41+
/// Gets the name of the route to use for generating the URL.
4242
/// </summary>
4343
public string? RouteName { get; }
4444

4545
/// <summary>
46-
/// Gets or sets the route data to use for generating the URL.
46+
/// Gets the route data to use for generating the URL.
4747
/// </summary>
4848
public RouteValueDictionary RouteValues { get; }
4949

src/Http/Http.Results/src/ChallengeResult.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ public static void ChallengeResultExecuting(ILogger logger, IList<string> authen
113113
}
114114
}
115115

116-
[LoggerMessage(1, LogLevel.Information, "Executing ChallengeResult with authentication schemes ({Schemes}).", EventName = "ChallengeResultExecuting")]
116+
[LoggerMessage(1, LogLevel.Information, "Executing ChallengeResult with authentication schemes ({Schemes}).", EventName = "ChallengeResultExecuting", SkipEnabledCheck = true)]
117117
private static partial void ChallengeResultExecuting(ILogger logger, string[] schemes);
118118
}
119119
}

src/Http/Http.Results/src/PhysicalFileResult.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ public Task ExecuteAsync(HttpContext httpContext)
4242
var fileInfo = GetFileInfoWrapper(FileName);
4343
if (!fileInfo.Exists)
4444
{
45-
throw new FileNotFoundException($"Could not find file: {FileName}");
45+
throw new FileNotFoundException($"Could not find file: {FileName}", FileName);
4646
}
4747

4848
var logger = httpContext.RequestServices.GetRequiredService<ILogger<PhysicalFileResult>>();

0 commit comments

Comments
 (0)