Skip to content

Commit 4a45fd8

Browse files
Remove unnecessary name attribute from EditForm
1 parent a4249f8 commit 4a45fd8

File tree

4 files changed

+5
-7
lines changed

4 files changed

+5
-7
lines changed

src/Components/Web/src/Forms/EditForm.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,6 @@ protected override void BuildRenderTree(RenderTreeBuilder builder)
153153
if (BindingContext != null)
154154
{
155155
var submitEventName = CombineStrings(BindingContext.Name, FormHandlerName);
156-
builder.AddAttribute(5, "name", submitEventName); // TODO: Remove this. Need to update a lot of E2E tests that look for it.
157156
builder.AddNamedEvent(5, "onsubmit", submitEventName ?? string.Empty);
158157
RenderSSRFormHandlingChildren(builder, 6);
159158
}

src/Components/test/E2ETest/ServerRenderingTests/FormHandlingTests/FormWithParentBindingContextTest.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -694,7 +694,7 @@ public void CanDispatchToNamedForm(bool suppressEnhancedNavigation)
694694
var dispatchToForm = new DispatchToForm(this)
695695
{
696696
Url = "forms/named-form",
697-
FormCssSelector = "form[name=named-form-handler]",
697+
FormCssSelector = "form",
698698
ExpectedActionValue = "forms/named-form?handler=named-form-handler",
699699
SuppressEnhancedNavigation = suppressEnhancedNavigation,
700700
};
@@ -709,7 +709,7 @@ public void CanBindFormValueFromNamedFormWithBody(bool suppressEnhancedNavigatio
709709
var dispatchToForm = new DispatchToForm(this)
710710
{
711711
Url = "forms/named-form-bound-parameter",
712-
FormCssSelector = "form[name=named-form-handler]",
712+
FormCssSelector = "form",
713713
ExpectedActionValue = "forms/named-form-bound-parameter?handler=named-form-handler",
714714
InputFieldId = "Parameter",
715715
InputFieldCssSelector = "input[name=Parameter]",
@@ -727,7 +727,7 @@ public void CanDispatchToNamedFormInNestedContext(bool suppressEnhancedNavigatio
727727
var dispatchToForm = new DispatchToForm(this)
728728
{
729729
Url = "forms/nested-named-form",
730-
FormCssSelector = "form[name=\"parent-context.named-form-handler\"]",
730+
FormCssSelector = "form",
731731
ExpectedActionValue = "forms/nested-named-form?handler=parent-context.named-form-handler",
732732
SuppressEnhancedNavigation = suppressEnhancedNavigation,
733733
};
@@ -742,7 +742,7 @@ public void CanBindFormValueFromNestedNamedFormWithBody(bool suppressEnhancedNav
742742
var dispatchToForm = new DispatchToForm(this)
743743
{
744744
Url = "forms/nested-named-form-bound-parameter",
745-
FormCssSelector = """form[name="parent-context.named-form-handler"]""",
745+
FormCssSelector = "form",
746746
ExpectedActionValue = "forms/nested-named-form-bound-parameter?handler=parent-context.named-form-handler",
747747
InputFieldId = "Parameter",
748748
InputFieldCssSelector = "input[name=Parameter]",

src/Components/test/E2ETest/ServerRenderingTests/FormHandlingTests/NamedFormNoParentBindingContextTest.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ public void CanDispatchToNamedFormNoParentBindingContext()
3131

3232
Browser.Exists(By.Id("ready"));
3333

34-
var form = Browser.Exists(By.CssSelector("form[name=named-form-handler]"));
34+
var form = Browser.Exists(By.CssSelector("form"));
3535
var formTarget = form.GetAttribute("action");
3636
var actionValue = form.GetDomAttribute("action");
3737
var baseUri = new Uri(_serverFixture.RootUri, ServerPathBase).ToString();

src/Components/test/testassets/Components.TestServer/RazorComponents/Pages/Forms/MultipleParametersMultipleFormsDoNotConflict.razor

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
@page "/forms/multiple-forms-bound-parameter-no-conflicts"
22
@using Microsoft.AspNetCore.Components.Forms
33

4-
54
<FormThatBindsInteger>
65
</FormThatBindsInteger>
76

0 commit comments

Comments
 (0)