Merge branch 'master' into merge/release/5.0-preview6-to-master

Author: sebastienros

.azure/pipelines/ci.yml

@@ -35,7 +35,7 @@ variables:
   - name: _UseHelixOpenQueues
     value: 'true'
   - name: _BuildArgs
-    value: ''
+    value: '/p:SkipTestBuild=true'
   - name: _PublishArgs
     value: ''
   - name: _SignType
@@ -66,6 +66,7 @@ variables:
     - name: _BuildArgs
       value: /p:TeamName=$(_TeamName)
              /p:OfficialBuildId=$(Build.BuildNumber)
+             /p:SkipTestBuild=true
     - name: _SignType
       value: real
 
@@ -81,7 +82,7 @@ variables:
 
   - ${{ if in(variables['Build.Reason'], 'PullRequest') }}:
     - name: _BuildArgs
-      value: ''
+      value: '/p:SkipTestBuild=true'
     - name: _SignType
       value: test
     - name: _PublishArgs
@@ -158,6 +159,7 @@ stages:
                 -noBuildRepoTasks
                 -pack
                 -noBuildDeps
+                -noBuildNative
                 $(_BuildArgs)
                 $(_InternalRuntimeDownloadArgs)
         condition: ne(variables['Build.Reason'], 'PullRequest')
@@ -503,16 +505,6 @@ stages:
       beforeBuild:
       - powershell: "& ./src/Servers/IIS/tools/UpdateIISExpressCertificate.ps1; & ./src/Servers/IIS/tools/update_schema.ps1"
         displayName: Setup IISExpress test certificates and schema
-      afterBuild:
-      - powershell: "& ./build.ps1 -CI -nobl -NoBuild -Test /p:RunQuarantinedTests=true"
-        displayName: Run Quarantined Tests
-        continueOnError: true
-      - task: PublishTestResults@2
-        displayName: Publish Quarantined Test Results
-        inputs:
-          testResultsFormat: 'xUnit'
-          testResultsFiles: '*.xml'
-          searchFolder: '$(Build.SourcesDirectory)/artifacts/TestResults/$(_BuildConfig)/Quarantined'
       artifacts:
       - name: Windows_Test_Dumps
         path: artifacts/dumps/
@@ -566,20 +558,6 @@ stages:
       beforeBuild:
       - bash: "./eng/scripts/install-nginx-mac.sh"
         displayName: Installing Nginx
-      afterBuild:
-      - bash: ./build.sh --ci --nobl --pack --no-build --no-restore --no-build-deps
-        displayName: Pack Packages (for Template tests)
-      - bash: ./src/ProjectTemplates/build.sh --ci --nobl --pack --no-restore --no-build-deps
-        displayName: Pack Templates (for Template tests)
-      - bash: ./build.sh --no-build --ci --nobl --test -p:RunQuarantinedTests=true
-        displayName: Run Quarantined Tests
-        continueOnError: true
-      - task: PublishTestResults@2
-        displayName: Publish Quarantined Test Results
-        inputs:
-          testResultsFormat: 'xUnit'
-          testResultsFiles: '*.xml'
-          searchFolder: '$(Build.SourcesDirectory)/artifacts/TestResults/$(_BuildConfig)/Quarantined'
       artifacts:
       - name: MacOS_Test_Logs
         path: artifacts/log/
@@ -604,20 +582,6 @@ stages:
         displayName: Installing Nginx
       - bash: "echo fs.inotify.max_user_watches=524288 | sudo tee -a /etc/sysctl.conf && sudo sysctl -p"
         displayName: Increase inotify limit
-      afterBuild:
-      - bash: ./build.sh --ci --nobl --pack --no-build --no-restore --no-build-deps
-        displayName: Pack Packages (for Template tests)
-      - bash: ./src/ProjectTemplates/build.sh --ci --nobl --pack --no-restore --no-build-deps
-        displayName: Pack Templates (for Template tests)
-      - bash: ./build.sh --no-build --ci --nobl --test -p:RunQuarantinedTests=true
-        displayName: Run Quarantined Tests
-        continueOnError: true
-      - task: PublishTestResults@2
-        displayName: Publish Quarantined Test Results
-        inputs:
-          testResultsFormat: 'xUnit'
-          testResultsFiles: '*.xml'
-          searchFolder: '$(Build.SourcesDirectory)/artifacts/TestResults/$(_BuildConfig)/Quarantined'
       artifacts:
       - name: Linux_Test_Logs
         path: artifacts/log/
@@ -730,6 +694,7 @@ stages:
 - ${{ if and(ne(variables['System.TeamProject'], 'public'), notin(variables['Build.Reason'], 'PullRequest')) }}:
   - template: /eng/common/templates/post-build/post-build.yml
     parameters:
-      # See https://github.com/dotnet/arcade/issues/2871
       enableSymbolValidation: false
+      enableSigningValidation: false
+      enableNugetValidation: false
       publishInstallersAndChecksums: true

.azure/pipelines/devBuilds.yml

@@ -8,15 +8,6 @@ trigger: none
 # no PR builds
 pr: none
 
-# Schedule this pipeline to run every midnight
-schedules:
-- cron: "0 8 * * *"
-  displayName: Daily midnight Dev builds
-  branches:
-    include:
-    - master
-  always: true
-
 stages:
 - stage: build_components
   displayName: Build Components
@@ -32,7 +23,7 @@ stages:
       - script: ./build.cmd
                 -ci
                 -arch x64
-                /bl:artifacts/log/build.components.x64.binlog
+                /bl:$(Build.SourcesDirectory)/artifacts/log/build.components.x64.binlog
         displayName: Build x64
         workingDirectory: ./src/Components
       artifacts:
@@ -55,7 +46,7 @@ stages:
       - script: ./build.cmd
                 -ci
                 -arch x64
-                /bl:artifacts/log/build.servers.x64.binlog
+                /bl:$(Build.SourcesDirectory)/artifacts/log/build.servers.x64.binlog
         displayName: Build x64
         workingDirectory: ./src/Servers
       artifacts:
@@ -78,7 +69,7 @@ stages:
       - script: ./build.cmd
                 -ci
                 -arch x64
-                /bl:artifacts/log/build.projectTemplates.x64.binlog
+                /bl:$(Build.SourcesDirectory)/artifacts/log/build.projectTemplates.x64.binlog
         displayName: Build x64
         workingDirectory: ./src/ProjectTemplates
       artifacts:
@@ -101,7 +92,7 @@ stages:
       - script: ./build.cmd
                 -ci
                 -arch x64
-                /bl:artifacts/log/build.all.x64.binlog
+                /bl:$(Build.SourcesDirectory)/artifacts/log/build.all.x64.binlog
         displayName: Build x64
       artifacts:
       - name: Windows_Logs

.azure/pipelines/helix-matrix.yml

@@ -30,7 +30,7 @@ jobs:
       displayName: Build shared fx
     - script: ./build.cmd -ci -nobl -noBuildRepoTasks -restore -noBuild -projects src/Grpc/**/*.csproj
       displayName: Restore interop projects
-    - script: .\build.cmd -ci -nobl -noBuildRepoTasks -NoRestore -test -all -projects eng\helix\helix.proj
+    - script: .\build.cmd -ci -nobl -noBuildRepoTasks -NoRestore -test -all -noBuildNative -projects eng\helix\helix.proj
               /p:IsHelixDaily=true /p:IsRequiredCheck=true /p:IsHelixJob=true /p:BuildInteropProjects=true
               /p:RunTemplateTests=true /p:ASPNETCORE_TEST_LOG_DIR=artifacts/log
       displayName: Run build.cmd helix target

.azure/pipelines/jobs/default-build.yml

@@ -164,7 +164,7 @@ jobs:
         displayName: Install JDK 11
       - ${{ if eq(parameters.isTestingJob, true) }}:
         - powershell: |
-            Write-Host "##vso[task.setvariable variable=SeleniumProcessTrackingFolder]$(BuildDirectory)\artifacts\tmp\selenium\"
+            Write-Host "##vso[task.setvariable variable=SeleniumProcessTrackingFolder]$(Build.SourcesDirectory)\artifacts\tmp\selenium\"
             ./eng/scripts/InstallGoogleChrome.ps1
           displayName: Install Chrome
     - ${{ if and(eq(parameters.installTar, 'true'), eq(parameters.agentOs, 'Windows')) }}:
@@ -238,13 +238,25 @@ jobs:
         continueOnError: true
         condition: always()
 
+    - ${{ if and(startsWith(parameters.jobDisplayName, 'Build:'), ne(variables['skipComponentGovernanceDetection'], 'true'), notin(variables['Build.Reason'], 'PullRequest')) }}:
+      - task: ms.vss-governance-buildtask.governance-build-task-component-detection.ComponentGovernanceComponentDetection@0
+        condition: and(succeeded(), ne(variables['CG_RAN'], 'true'))
+        displayName: 'Component Detection'
+        inputs:
+          ${{ if eq(parameters.agentOs, 'Windows') }}:
+            ignoreDirectories: '.dotnet,.packages,artifacts\log,artifacts\symbols,artifacts\tmp'
+          ${{ if ne(parameters.agentOs, 'Windows') }}:
+            ignoreDirectories: '.dotnet,.packages,artifacts/log,artifacts/symbols,artifacts/tmp'
+          sourceScanPath: $(Build.SourcesDirectory)
+          verbosity: Verbose
+
     - ${{ each artifact in parameters.artifacts }}:
       - task: PublishBuildArtifacts@1
         displayName: Upload artifacts from ${{ artifact.path }}
         condition: and(or(succeeded(), eq('${{ artifact.publishOnError }}', 'true')), or(eq(variables['system.pullrequest.isfork'], false), eq('${{ artifact.includeForks }}', 'true')))
         continueOnError: true
         inputs:
-          pathtoPublish: $(BuildDirectory)/${{ artifact.path }}
+          pathtoPublish: $(Build.SourcesDirectory)/${{ artifact.path }}
           ${{ if eq(artifact.name, '') }}:
             artifactName: artifacts-$(AgentOsName)-$(BuildConfiguration)
           ${{ if ne(artifact.name, '') }}:

.azure/pipelines/quarantined-tests.yml

@@ -25,10 +25,10 @@ variables:
 jobs:
 - template: jobs/default-build.yml
   parameters:
-    jobName: Helix_quarantine_x64
-    jobDisplayName: 'Tests: Helix Quarantine x64'
+    jobName: Helix_quarantined_x64
+    jobDisplayName: 'Tests: Helix'
     agentOs: Windows
-    timeoutInMinutes: 240
+    timeoutInMinutes: 180
     steps:
     # Build the shared framework
     - script: ./build.cmd -ci -nobl -all -pack -arch x64 /p:ASPNETCORE_TEST_LOG_DIR=artifacts/log
@@ -46,3 +46,101 @@ jobs:
     - name: Helix_logs
       path: artifacts/log/
       publishOnError: true
+
+- template: jobs/default-build.yml
+  parameters:
+    jobName: Windows_Quarantined_x64
+    jobDisplayName: 'Tests: Windows x64'
+    agentOs: Windows
+    timeoutInMinutes: 180
+    isTestingJob: true
+    steps:
+    - powershell: "& ./build.ps1 -CI -nobl -all -pack -NoBuildJava"
+      displayName: Build
+    # The templates part can be removed when the Blazor Templates run on Helix
+    - script: ./src/ProjectTemplates/build.cmd -ci -nobl -pack -NoRestore -NoBuilddeps "/p:RunTemplateTests=true"
+      displayName: Pack Templates
+    - script: ./build.cmd -ci -nobl -test -NoRestore -NoBuild -NoBuilddeps "/p:RunTemplateTests=true /p:RunQuarantinedTests=true /p:SkipHelixReadyTests=true"
+      displayName: Run Quarantined Tests
+      condition: always()
+    - task: PublishTestResults@2
+      displayName: Publish Quarantined Test Results
+      inputs:
+        testResultsFormat: 'xUnit'
+        testResultsFiles: '*.xml'
+        searchFolder: '$(Build.SourcesDirectory)/artifacts/TestResults/$(_BuildConfig)/Quarantined'
+      condition: always()
+    artifacts:
+    - name: Windows_Quarantined_Test_Logs
+      path: artifacts/log/
+      publishOnError: true
+      includeForks: true
+    - name: Windows_Quarantined_Test_Results
+      path: artifacts/TestResults/
+      publishOnError: true
+      includeForks: true
+
+- template: jobs/default-build.yml
+  parameters:
+    jobName: MacOS_Quarantined_Test
+    jobDisplayName: "Tests: macOS 10.14"
+    agentOs: macOS
+    timeoutInMinutes: 180
+    isTestingJob: true
+    steps:
+    - bash: ./build.sh --all --pack --ci --nobl --no-build-java
+      displayName: Build
+    # The templates part can be removed when the Blazor Templates run on Helix
+    - bash: ./src/ProjectTemplates/build.sh --ci --nobl --pack --no-restore --no-build-deps
+      displayName: Pack Templates (for Template tests)
+    - bash: ./build.sh --no-build --ci --nobl --test -p:RunTemplateTests=true -p:RunQuarantinedTests=true -p:SkipHelixReadyTests=true
+      displayName: Run Quarantined Tests
+    - task: PublishTestResults@2
+      displayName: Publish Quarantined Test Results
+      inputs:
+        testResultsFormat: 'xUnit'
+        testResultsFiles: '*.xml'
+        searchFolder: '$(Build.SourcesDirectory)/artifacts/TestResults/$(_BuildConfig)/Quarantined'
+      condition: always()
+    artifacts:
+    - name: MacOS_Quarantined_Test_Logs
+      path: artifacts/log/
+      publishOnError: true
+      includeForks: true
+    - name: MacOS_Quarantined_Test_Results
+      path: artifacts/TestResults/
+      publishOnError: true
+      includeForks: true
+
+- template: jobs/default-build.yml
+  parameters:
+    jobName: Linux_Quarantined_Test
+    jobDisplayName: "Tests: Ubuntu 16.04 x64"
+    agentOs: Linux
+    timeoutInMinutes: 180
+    isTestingJob: true
+    useHostedUbuntu: false
+    steps:
+    - bash: ./build.sh --all --pack --ci --nobl --no-build-java
+      displayName: Build
+    # The templates part can be removed when the Blazor Templates run on Helix
+    - bash: ./src/ProjectTemplates/build.sh --ci --nobl --pack --no-restore --no-build-deps
+      displayName: Pack Templates (for Template tests)
+    - bash: ./build.sh --no-build --ci --nobl --test -p:RunTemplateTests=true -p:RunQuarantinedTests=true -p:SkipHelixReadyTests=true
+      displayName: Run Quarantined Tests
+    - task: PublishTestResults@2
+      displayName: Publish Quarantined Test Results
+      inputs:
+        testResultsFormat: 'xUnit'
+        testResultsFiles: '*.xml'
+        searchFolder: '$(Build.SourcesDirectory)/artifacts/TestResults/$(_BuildConfig)/Quarantined'
+      condition: always()
+    artifacts:
+    - name: Linux_Quarantined_Test_Logs
+      path: artifacts/log/
+      publishOnError: true
+      includeForks: true
+    - name: Linux_Quarantined_Test_Results
+      path: artifacts/TestResults/
+      publishOnError: true
+      includeForks: true

.github/ISSUE_TEMPLATE/bug_report.md

@@ -1,13 +1,13 @@
 ---
-name: Bug report
+name: 🐞 Bug report
 about: Create a report about something that is not working
 ---
 
 <!--
 
 More information on our issue management policies can be found here: https://aka.ms/aspnet/issue-policies
 
-Please keep in mind that the GitHub issue tracker is not intended as a general support forum, but for reporting non-security bugs and feature requests.
+Please keep in mind that the GitHub issue tracker is not intended as a general support forum, but for reporting **non-security** bugs and feature requests.
 
 If you believe you have an issue that affects the SECURITY of the platform, please do NOT create an issue and instead email your issue details to [email protected]. Your report may be eligible for our [bug bounty](https://www.microsoft.com/en-us/msrc/bounty-dot-net-core) but ONLY if it is reported through email.
 For other types of questions, consider using [StackOverflow](https://stackoverflow.com).
@@ -19,15 +19,17 @@ A clear and concise description of what the bug is.
 
 ### To Reproduce
 <!--
-What steps can we follow to reproduce the issue?
+We ❤ code! Point us to a minimalistic repro project hosted in a GitHub repo.
+For a repro project, create a new ASP.NET Core project using the template of your your choice, apply the minimum required code to result in the issue you're observing.
 
-We ❤ code! Include a complete code listing or point us to a minimalistic GitHub repo.
-
-``` C#
-Console.WriteLine("Hello, World!");
-```
+We will close this issue if:
+- the repro project you share with us is complex. We can't investigate custom projects, so don't point us to such, please.
+- if we will not be able to repro the behavior you're reporting
+-->
 
-Got Exceptions? Include both the message and the stack trace
+### Exceptions (if any)
+<!-- 
+Include the exception you get when facing this issue
 -->
 
 ### Further technical details

.github/ISSUE_TEMPLATE/feature_request.md

@@ -1,5 +1,5 @@
 ---
-name: Feature request
+name: 💡 Feature request
 about: Suggest an idea for this project
 ---
 

.vscode/extensions.json

@@ -1,6 +1,6 @@
 {
   "recommendations": [
-    "ms-vscode.csharp",
+    "ms-dotnettools.csharp",
     "ms-vscode.PowerShell",
     "EditorConfig.EditorConfig"
   ]