Clean up

Author: JamesNK

src/Hosting/Hosting/src/Internal/HostingApplicationDiagnostics.cs

@@ -390,7 +390,7 @@ private void RecordRequestStartMetrics(HttpContext httpContext)
         hasDiagnosticListener = false;
 
         var headers = httpContext.Request.Headers;
-        var activity = ActivityCreator.CreateFromRemoteActivity(
+        var activity = ActivityCreator.CreateFromRemote(
             _activitySource,
             _propagator,
             headers,

src/Shared/Diagnostics/ActivityCreator.cs

@@ -10,7 +10,7 @@ internal static class ActivityCreator
     /// <summary>
     /// Create an activity with details received from a remote source.
     /// </summary>
-    public static Activity? CreateFromRemoteActivity(
+    public static Activity? CreateFromRemote(
         ActivitySource activitySource,
         DistributedContextPropagator propagator,
         object distributedContextCarrier,

src/SignalR/clients/csharp/Client.Core/src/HubConnection.cs

@@ -1087,6 +1087,10 @@ private async Task InvokeStreamCore(ConnectionState connectionState, string meth
 
     private static void InjectHeaders(HubInvocationMessage invocationMessage)
     {
+        // TODO:
+        // This sends info about the current activity, regardless of the activity source, to the SignalR server.
+        // When SignalR client supports client activities this logic should be updated to only send headers
+        // if the SignalR client activity is created. The goal is to match the behavior of distributed tracing in HttpClient.
         if (Activity.Current is { } currentActivity)
         {
             DistributedContextPropagator.Current.Inject(currentActivity, invocationMessage, static (carrier, key, value) =>

src/SignalR/common/testassets/Tests.Utils/TestClient.cs

@@ -8,7 +8,6 @@
 using Microsoft.AspNetCore.Connections.Features;
 using Microsoft.AspNetCore.Internal;
 using Microsoft.AspNetCore.SignalR.Protocol;
-using System.Reflection.PortableExecutable;
 
 #if TESTUTILS
 using Microsoft.AspNetCore.InternalTesting;

src/SignalR/server/Core/src/Internal/DefaultHubDispatcher.cs

@@ -861,7 +861,7 @@ public override IReadOnlyList<Type> GetParameterTypes(string methodName)
         Activity? activity;
         if (headers != null)
         {
-            activity = ActivityCreator.CreateFromRemoteActivity(
+            activity = ActivityCreator.CreateFromRemote(
                 activitySource,
                 propagator,
                 headers,