Use string.StartsWith(char) and string.EndsWith(char) where applicable (#44310)

Author: meziantou

src/Components/test/E2ETest/Infrastructure/WebDriverExtensions/BasicTestAppAuthenticationWebDriverExtensions.cs

@@ -10,7 +10,7 @@ internal static class BasicTestAppAuthenticationWebDriverExtensions
 {
     public static void SignInAs(this IWebDriver browser, Uri baseUri, string usernameOrNull, string rolesOrNull, bool useSeparateTab = false)
     {
-        var basePath = baseUri.LocalPath.EndsWith("/", StringComparison.Ordinal) ? baseUri.LocalPath : baseUri.LocalPath + "/";
+        var basePath = baseUri.LocalPath.EndsWith('/') ? baseUri.LocalPath : baseUri.LocalPath + "/";
         var authenticationPageUrl = $"{basePath}Authentication";
         var baseRelativeUri = usernameOrNull == null
             ? $"{authenticationPageUrl}?signout=true"

src/Grpc/JsonTranscoding/src/Microsoft.AspNetCore.Grpc.JsonTranscoding/Internal/JsonTranscodingRouteAdapter.cs

@@ -22,7 +22,7 @@ namespace Microsoft.AspNetCore.Grpc.JsonTranscoding.Internal;
 /// For example, consider a multi-segment parameter route:
 /// - Before: /v1/{book.name=shelves/*/books/*}
 /// - After: /v1/shelves/{__Complex_book.name_2}/books/{__Complex_book.name_4}
-/// 
+///
 /// It is rewritten so that any * or ** segments become ASP.NET Core route parameters. These parameter
 /// names are never used by the user, and instead they're reconstructed into the final value by the
 /// adapter and then added to the HttpRequest.RouteValues collection.
@@ -178,7 +178,7 @@ private static SegmentType GetSegmentType(string segment)
         {
             return SegmentType.CatchAll;
         }
-        else if (segment.StartsWith("*", StringComparison.Ordinal))
+        else if (segment.StartsWith('*'))
         {
             return SegmentType.Any;
         }

src/Http/Headers/src/ContentDispositionHeaderValue.cs

@@ -400,7 +400,7 @@ private StringSegment GetName(string parameter)
         {
             string? result;
             // filename*=utf-8'lang'%7FMyString
-            if (parameter.EndsWith("*", StringComparison.Ordinal))
+            if (parameter.EndsWith('*'))
             {
                 if (TryDecode5987(nameParameter.Value, out result))
                 {

src/Http/Http.Abstractions/src/Extensions/MapExtensions.cs

@@ -58,7 +58,7 @@ public static IApplicationBuilder Map(this IApplicationBuilder app, PathString p
             throw new ArgumentNullException(nameof(configuration));
         }
 
-        if (pathMatch.HasValue && pathMatch.Value!.EndsWith("/", StringComparison.Ordinal))
+        if (pathMatch.HasValue && pathMatch.Value!.EndsWith('/'))
         {
             throw new ArgumentException("The path must not end with a '/'", nameof(pathMatch));
         }

src/Http/Http.Results/src/VirtualFileHttpResult.cs

@@ -152,7 +152,7 @@ private static Task ExecuteCoreAsync(HttpContext httpContext, RangeItemHeaderVal
     internal IFileInfo GetFileInformation(IFileProvider fileProvider)
     {
         var normalizedPath = FileName;
-        if (normalizedPath.StartsWith("~", StringComparison.Ordinal))
+        if (normalizedPath.StartsWith('~'))
         {
             normalizedPath = normalizedPath.Substring(1);
         }

src/Http/Routing.Abstractions/src/VirtualPathData.cs

@@ -86,7 +86,7 @@ private static string NormalizePath(string path)
             return string.Empty;
         }
 
-        if (!path.StartsWith("/", StringComparison.Ordinal))
+        if (!path.StartsWith('/'))
         {
             return "/" + path;
         }

src/Http/Routing/src/ParameterPolicyActivator.cs

@@ -35,7 +35,7 @@ public static T ResolveParameterPolicy<T>(
 
         string argumentString;
         var indexOfFirstOpenParens = inlineParameterPolicy.IndexOf('(');
-        if (indexOfFirstOpenParens >= 0 && inlineParameterPolicy.EndsWith(")", StringComparison.Ordinal))
+        if (indexOfFirstOpenParens >= 0 && inlineParameterPolicy.EndsWith(')'))
         {
             parameterPolicyKey = inlineParameterPolicy.Substring(0, indexOfFirstOpenParens);
             argumentString = inlineParameterPolicy.Substring(

src/Http/Routing/src/Patterns/RoutePatternParser.cs

@@ -220,7 +220,7 @@ private static bool ParseParameter(Context context, List<RoutePatternPart> parts
         var templatePart = RouteParameterParser.ParseRouteParameter(decoded);
 
         // See #475 - this is here because InlineRouteParameterParser can't return errors
-        if (decoded.StartsWith("*", StringComparison.Ordinal) && decoded.EndsWith("?", StringComparison.Ordinal))
+        if (decoded.StartsWith('*') && decoded.EndsWith('?'))
         {
             context.Error = Resources.TemplateRoute_CatchAllCannotBeOptional;
             return false;
@@ -466,11 +466,11 @@ private static string TrimPrefix(string routePattern)
         {
             return routePattern.Substring(2);
         }
-        else if (routePattern.StartsWith("/", StringComparison.Ordinal))
+        else if (routePattern.StartsWith('/'))
         {
             return routePattern.Substring(1);
         }
-        else if (routePattern.StartsWith("~", StringComparison.Ordinal))
+        else if (routePattern.StartsWith('~'))
         {
             throw new RoutePatternException(routePattern, Resources.TemplateRoute_InvalidRouteTemplate);
         }

src/Http/Routing/src/RouteCollection.cs

@@ -176,7 +176,7 @@ public virtual async Task RouteAsync(RouteContext context)
                 queryString = queryString.ToLowerInvariant();
             }
 
-            if (_options.AppendTrailingSlash && !urlWithoutQueryString.EndsWith("/", StringComparison.Ordinal))
+            if (_options.AppendTrailingSlash && !urlWithoutQueryString.EndsWith('/'))
             {
                 urlWithoutQueryString += "/";
             }

src/Middleware/StaticFiles/src/Infrastructure/SharedOptions.cs

@@ -29,7 +29,7 @@ public PathString RequestPath
         get { return _requestPath; }
         set
         {
-            if (value.HasValue && value.Value!.EndsWith("/", StringComparison.Ordinal))
+            if (value.HasValue && value.Value!.EndsWith('/'))
             {
                 throw new ArgumentException("Request path must not end in a slash");
             }

src/Mvc/Mvc.Core/src/ApplicationModels/AttributeRouteModel.cs

@@ -160,7 +160,7 @@ public static bool IsOverridePattern([StringSyntax("Route")] string? template)
     {
         return template != null &&
             (template.StartsWith("~/", StringComparison.Ordinal) ||
-            template.StartsWith("/", StringComparison.Ordinal));
+            template.StartsWith('/'));
     }
 
     private static string? ChooseName(
@@ -192,7 +192,7 @@ public static bool IsOverridePattern([StringSyntax("Route")] string? template)
             return right;
         }
 
-        if (left!.EndsWith("/", StringComparison.Ordinal))
+        if (left!.EndsWith('/'))
         {
             return left + right;
         }
@@ -225,7 +225,7 @@ private static bool IsEmptyLeftSegment(string? template)
         }
 
         var startIndex = 0;
-        if (result.StartsWith("/", StringComparison.Ordinal))
+        if (result.StartsWith('/'))
         {
             startIndex = 1;
         }
@@ -241,7 +241,7 @@ private static bool IsEmptyLeftSegment(string? template)
         }
 
         var subStringLength = result.Length - startIndex;
-        if (result.EndsWith("/", StringComparison.Ordinal))
+        if (result.EndsWith('/'))
         {
             subStringLength--;
         }

src/Mvc/Mvc.Core/src/Formatters/FormatterMappings.cs

@@ -114,7 +114,7 @@ private static string RemovePeriodIfPresent(string format)
             throw new ArgumentException(Resources.ArgumentCannotBeNullOrEmpty, nameof(format));
         }
 
-        if (format.StartsWith(".", StringComparison.Ordinal))
+        if (format.StartsWith('.'))
         {
             if (format == ".")
             {

src/Mvc/Mvc.Core/src/Infrastructure/VirtualFileResultExecutor.cs

@@ -128,7 +128,7 @@ internal static IFileInfo GetFileInformation(VirtualFileResult result, IWebHostE
         }
 
         var normalizedPath = result.FileName;
-        if (normalizedPath.StartsWith("~", StringComparison.Ordinal))
+        if (normalizedPath.StartsWith('~'))
         {
             normalizedPath = normalizedPath.Substring(1);
         }

src/Mvc/Mvc.Core/src/Routing/UrlHelperBase.cs

@@ -443,12 +443,12 @@ internal static void AppendPathAndFragment(StringBuilder builder, PathString pat
             {
                 builder.Append(pathBase.Value);
 
-                if (pathBase.Value.EndsWith("/", StringComparison.Ordinal))
+                if (pathBase.Value.EndsWith('/'))
                 {
                     builder.Length--;
                 }
 
-                if (!virtualPath.StartsWith("/", StringComparison.Ordinal))
+                if (!virtualPath.StartsWith('/'))
                 {
                     builder.Append('/');
                 }
@@ -483,7 +483,7 @@ private bool TryFastGenerateUrl(
                 url = "/";
                 return true;
             }
-            else if (virtualPath.StartsWith("/", StringComparison.Ordinal))
+            else if (virtualPath.StartsWith('/'))
             {
                 url = virtualPath;
                 return true;

src/Mvc/Mvc.Razor.RuntimeCompilation/src/FileProviderRazorProjectFileSystem.cs

@@ -78,8 +78,8 @@ private IEnumerable<RazorProjectItem> EnumerateFiles(IDirectoryContents director
 
     private static string JoinPath(string path1, string path2)
     {
-        var hasTrailingSlash = path1.EndsWith("/", StringComparison.Ordinal);
-        var hasLeadingSlash = path2.StartsWith("/", StringComparison.Ordinal);
+        var hasTrailingSlash = path1.EndsWith('/');
+        var hasLeadingSlash = path2.StartsWith('/');
         if (hasLeadingSlash && hasTrailingSlash)
         {
             return string.Concat(path1, path2.AsSpan(1));

src/Mvc/Mvc.RazorPages/src/ApplicationModels/PageRouteModelFactory.cs

@@ -86,7 +86,7 @@ internal bool TryParseAreaPath(
         const string AreaPagesRoot = "/Pages/";
 
         result = default;
-        Debug.Assert(relativePath.StartsWith("/", StringComparison.Ordinal));
+        Debug.Assert(relativePath.StartsWith('/'));
         // Parse the area root directory.
         var areaRootEndIndex = relativePath.IndexOf('/', startIndex: 1);
         if (areaRootEndIndex == -1 ||
@@ -139,7 +139,7 @@ private static string CreateAreaRoute(string areaName, string viewEnginePath)
         // Result = /Products/List/Categories
         Debug.Assert(!string.IsNullOrEmpty(areaName));
         Debug.Assert(!string.IsNullOrEmpty(viewEnginePath));
-        Debug.Assert(viewEnginePath.StartsWith("/", StringComparison.Ordinal));
+        Debug.Assert(viewEnginePath.StartsWith('/'));
 
         return string.Create(1 + areaName.Length + viewEnginePath.Length, (areaName, viewEnginePath), (span, tuple) =>
         {
@@ -172,8 +172,8 @@ private static SelectorModel CreateSelectorModel(string prefix, string? routeTem
 
     private static string NormalizeDirectory(string directory)
     {
-        Debug.Assert(directory.StartsWith("/", StringComparison.Ordinal));
-        if (directory.Length > 1 && !directory.EndsWith("/", StringComparison.Ordinal))
+        Debug.Assert(directory.StartsWith('/'));
+        if (directory.Length > 1 && !directory.EndsWith('/'))
         {
             return directory + "/";
         }

src/Mvc/Mvc.RazorPages/src/DependencyInjection/RazorPagesRazorViewEngineOptionsSetup.cs

@@ -65,11 +65,11 @@ public void Configure(RazorViewEngineOptions options)
 
     private static string CombinePath(string path1, string path2)
     {
-        if (path1.EndsWith("/", StringComparison.Ordinal) || path2.StartsWith("/", StringComparison.Ordinal))
+        if (path1.EndsWith('/') || path2.StartsWith('/'))
         {
             return path1 + path2;
         }
-        else if (path1.EndsWith("/", StringComparison.Ordinal) && path2.StartsWith("/", StringComparison.Ordinal))
+        else if (path1.EndsWith('/') && path2.StartsWith('/'))
         {
             return string.Concat(path1, path2.AsSpan(1));
         }

src/Mvc/Mvc.ViewFeatures/src/NameAndIdProvider.cs

@@ -176,7 +176,7 @@ public static string GetFullHtmlFieldName(ViewContext viewContext, string expres
 
         previousNameAndId.HtmlFieldPrefix = htmlFieldPrefix;
         previousNameAndId.Expression = expression;
-        if (expression.StartsWith("[", StringComparison.Ordinal))
+        if (expression.StartsWith('['))
         {
             // The expression might represent an indexer access, in which case  with a 'dot' would be invalid.
             previousNameAndId.OutputFullName = htmlFieldPrefix + expression;

src/Mvc/Mvc.ViewFeatures/src/TemplateInfo.cs

@@ -97,7 +97,7 @@ public string GetFullHtmlFieldName(string partialFieldName)
             return partialFieldName;
         }
 
-        if (partialFieldName.StartsWith("[", StringComparison.Ordinal))
+        if (partialFieldName.StartsWith('['))
         {
             // The partialFieldName might represent an indexer access, in which case combining
             // with a 'dot' would be invalid.

src/Security/Authentication/OpenIdConnect/src/OpenIdConnectHandler.cs

@@ -1290,7 +1290,7 @@ private string BuildRedirectUriIfRelative(string uri)
             return uri;
         }
 
-        if (!uri.StartsWith("/", StringComparison.Ordinal))
+        if (!uri.StartsWith('/'))
         {
             return uri;
         }

src/Security/Authentication/OpenIdConnect/src/OpenIdConnectPostConfigureOptions.cs

@@ -87,7 +87,7 @@ public void PostConfigure(string? name, OpenIdConnectOptions options)
                 if (string.IsNullOrEmpty(options.MetadataAddress) && !string.IsNullOrEmpty(options.Authority))
                 {
                     options.MetadataAddress = options.Authority;
-                    if (!options.MetadataAddress.EndsWith("/", StringComparison.Ordinal))
+                    if (!options.MetadataAddress.EndsWith('/'))
                     {
                         options.MetadataAddress += "/";
                     }

src/Security/Authentication/WsFederation/src/WsFederationHandler.cs

@@ -418,7 +418,7 @@ private string BuildRedirectUriIfRelative(string uri)
             return uri;
         }
 
-        if (!uri.StartsWith("/", StringComparison.Ordinal))
+        if (!uri.StartsWith('/'))
         {
             return uri;
         }

src/Servers/HttpSys/src/UrlPrefix.cs

@@ -88,7 +88,7 @@ public static UrlPrefix Create(string scheme, string host, int? portValue, strin
         {
             path = "/";
         }
-        else if (!path.EndsWith("/", StringComparison.Ordinal))
+        else if (!path.EndsWith('/'))
         {
             path += "/";
         }