Clean up shared code

Author: Tratcher

src/Servers/HttpSys/src/NativeInterop/HttpApi.cs

@@ -3,7 +3,6 @@
 
 using System.Diagnostics.CodeAnalysis;
 using System.Runtime.InteropServices;
-using Microsoft.AspNetCore.HttpSys.Internal;
 using Windows.Win32;
 using Windows.Win32.Networking.HttpServer;
 

src/Shared/HttpSys/NativeInterop/SafeNativeOverlapped.cs renamed to src/Servers/HttpSys/src/NativeInterop/SafeNativeOverlapped.cs

@@ -4,13 +4,16 @@
 using System.Diagnostics;
 using System.Runtime.InteropServices;
 
-namespace Microsoft.AspNetCore.HttpSys.Internal;
+namespace Microsoft.AspNetCore.Server.HttpSys;
 
 internal sealed class SafeNativeOverlapped : SafeHandle
 {
     internal static readonly SafeNativeOverlapped Zero = new SafeNativeOverlapped();
     private readonly ThreadPoolBoundHandle? _boundHandle;
 
+    private static bool HasShutdownStarted => Environment.HasShutdownStarted
+                || AppDomain.CurrentDomain.IsFinalizingForUnload();
+
     public SafeNativeOverlapped()
         : base(IntPtr.Zero, true)
     {
@@ -33,9 +36,9 @@ protected override bool ReleaseHandle()
         Debug.Assert(_boundHandle != null, "ReleaseHandle can't be called on SafeNativeOverlapped.Zero.");
 
         IntPtr oldHandle = Interlocked.Exchange(ref handle, IntPtr.Zero);
-        // Do not call free durring AppDomain shutdown, there may be an outstanding operation.
+        // Do not call free during AppDomain shutdown, there may be an outstanding operation.
         // Overlapped will take care calling free when the native callback completes.
-        if (oldHandle != IntPtr.Zero && !NclUtilities.HasShutdownStarted)
+        if (oldHandle != IntPtr.Zero && !HasShutdownStarted)
         {
             unsafe
             {

src/Servers/HttpSys/src/RequestProcessing/ClientCertLoader.cs

@@ -7,7 +7,6 @@
 using System.Security;
 using System.Security.Cryptography;
 using System.Security.Cryptography.X509Certificates;
-using Microsoft.AspNetCore.HttpSys.Internal;
 using Windows.Win32.Networking.HttpServer;
 
 namespace Microsoft.AspNetCore.Server.HttpSys;
@@ -16,7 +15,7 @@ namespace Microsoft.AspNetCore.Server.HttpSys;
 // failures are handled internally and reported via ClientCertException or ClientCertError.
 internal sealed unsafe partial class ClientCertLoader : IAsyncResult, IDisposable
 {
-    private const uint CertBoblSize = 1500;
+    private const uint CertBlobSize = 1500;
     private static readonly IOCompletionCallback IOCallback = new IOCompletionCallback(WaitCallback);
 
     private SafeNativeOverlapped? _overlapped;
@@ -37,7 +36,7 @@ internal ClientCertLoader(RequestContext requestContext, CancellationToken cance
         _tcs = new TaskCompletionSource<object?>();
         // we will use this overlapped structure to issue async IO to ul
         // the event handle will be put in by the BeginHttpApi2.ERROR_SUCCESS() method
-        Reset(CertBoblSize);
+        Reset(CertBlobSize);
 
         if (cancellationToken.CanBeCanceled)
         {
@@ -151,7 +150,7 @@ private void Reset(uint size)
     // HTTP.SYS will not do this for you automatically
     internal Task LoadClientCertificateAsync()
     {
-        var size = CertBoblSize;
+        var size = CertBlobSize;
         bool retry;
         do
         {

src/Servers/HttpSys/src/RequestProcessing/RequestStreamAsyncResult.cs

@@ -3,7 +3,6 @@
 
 using System.Diagnostics.CodeAnalysis;
 using System.Runtime.InteropServices;
-using Microsoft.AspNetCore.HttpSys.Internal;
 
 namespace Microsoft.AspNetCore.Server.HttpSys;
 

src/Servers/HttpSys/src/RequestProcessing/ResponseStreamAsyncResult.cs

@@ -3,7 +3,6 @@
 
 using System.Diagnostics;
 using System.Runtime.InteropServices;
-using Microsoft.AspNetCore.HttpSys.Internal;
 using Windows.Win32.Foundation;
 using Windows.Win32.Networking.HttpServer;