Skip to content

Commit 059e2fd

Browse files
authored
Remove Internal.AspNetCore.Analyzers (#24693)
* Remove Internal.AspNetCore.Analyzers This resolves build flakiness caused by referencing the analyzer: ``` 2020-08-07T21:22:39.1149296Z ##[error].dotnet\sdk\5.0.100-rc.1.20379.10\Microsoft.Common.CurrentVersion.targets(4188,5): error MSB3026: (NETCORE_ENGINEERING_TELEMETRY=Build) Could not copy "F:\workspace\_work\1\s\artifacts\obj\Internal.AspNetCore.Analyzers\Release\netstandard1.3\Internal.AspNetCore.Analyzers.dll" to "F:\workspace\_work\1\s\artifacts\bin\Internal.AspNetCore.Analyzers\Release\netstandard1.3\Internal.AspNetCore.Analyzers.dll". Beginning retry 1 in 1000ms. The process cannot access the file 'F:\workspace\_work\1\s\artifacts\bin\Internal.AspNetCore.Analyzers\Release\netstandard1.3\Internal.AspNetCore.Analyzers.dll' because it is being used by another process. ``` The analyzer checks if pubternal types are being exposed in public APIs. We no longer author pubternal types, so this is no longer a concern. * Remove DisablePubternalApiCheck
1 parent 5fbd1eb commit 059e2fd

File tree

11 files changed

+0
-628
lines changed

11 files changed

+0
-628
lines changed

Directory.Build.props

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -140,20 +140,6 @@
140140
<InternalInstallerBaseName>$(RuntimeInstallerBaseName)-internal</InternalInstallerBaseName>
141141
</PropertyGroup>
142142

143-
<ItemGroup
144-
Condition="'$(DisablePubternalApiCheck)' != 'true'
145-
AND '$(IsTestProject)' != 'true'
146-
AND '$(IsBenchmarkProject)' != 'true'
147-
AND '$(IsTestAssetProject)' != 'true'
148-
AND '$(MSBuildProjectName)' != 'Internal.AspNetCore.Analyzers'
149-
AND '$(MSBuildProjectExtension)' == '.csproj'">
150-
<ProjectReference
151-
Include="$(RepoRoot)src\Analyzers\Internal.AspNetCore.Analyzers\src\Internal.AspNetCore.Analyzers.csproj"
152-
ReferenceOutputAssembly="false"
153-
OutputItemType="Analyzer"
154-
PrivateAssets="All" />
155-
</ItemGroup>
156-
157143
<!-- Compilation options which apply to all languages. Language-specific options should be set in eng/targets/$(lang).Common.props -->
158144
<PropertyGroup>
159145
<BuildArchitecture>$([System.Runtime.InteropServices.RuntimeInformation]::ProcessArchitecture.ToString().ToLowerInvariant())</BuildArchitecture>

src/Analyzers/Internal.AspNetCore.Analyzers/src/Internal.AspNetCore.Analyzers.csproj

Lines changed: 0 additions & 26 deletions
This file was deleted.

src/Analyzers/Internal.AspNetCore.Analyzers/src/PubternalityAnalyzer.cs

Lines changed: 0 additions & 279 deletions
This file was deleted.

src/Analyzers/Internal.AspNetCore.Analyzers/src/PubturnalityDescriptors.cs

Lines changed: 0 additions & 25 deletions
This file was deleted.

src/Analyzers/Internal.AspNetCore.Analyzers/test/Internal.AspNetCore.Analyzers.Tests.csproj

Lines changed: 0 additions & 15 deletions
This file was deleted.

0 commit comments

Comments
 (0)