[tests] fix test failures on Windows #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: https://github.com/xamarin/xamarin-android/blob/b0e6c579f773e55419573e210b648d81b78360ef/src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/Utilities/BaseTest.cs#L237 Just a few minor things to get these working: - We need `@echo off` on Windows - `echo` doesn't need quotes, or it echos the quotes - We don't need to emit `jvm.dll` as `jvm.dll.cmd` - There is one test checking `PATH`, which doesn't occur on Windows. It doesn't look in `%PATH%`, so we should ignore it on Windows.
Member
Author
|
It probably wouldn't take much to make a quick VSTS job to build & run tests on Windows, if we think that would be useful. |
Contributor
|
@jonathanpeppers: Given that these tests have likely never executed on Windows before, I think it would be a good idea to get a quick VSTS job going. |
Member
Author
jonathanpeppers
added a commit
to jonathanpeppers/xamarin-android
that referenced
this pull request
Aug 16, 2018
Context; dotnet/android-tools@917d3b3...9e78d6e Fixes for OpenJDK: dotnet/android-tools#43 dotnet/android-tools#45 Better logging: dotnet/android-tools#46 Fix for missing JDKs on MacOS: dotnet/android-tools#48 Tests now pass on Windows: dotnet/android-tools#47
grendello
pushed a commit
to dotnet/android
that referenced
this pull request
Aug 17, 2018
Context; dotnet/android-tools@917d3b3...9e78d6e Fixes for OpenJDK: dotnet/android-tools#43 dotnet/android-tools#45 Better logging: dotnet/android-tools#46 Fix for missing JDKs on MacOS: dotnet/android-tools#48 Tests now pass on Windows: dotnet/android-tools#47
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: https://github.com/xamarin/xamarin-android/blob/b0e6c579f773e55419573e210b648d81b78360ef/src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/Utilities/BaseTest.cs#L237
Just a few minor things to get these working:
@echo offon Windowsechodoesn't need quotes, or it echos the quotesjvm.dllasjvm.dll.cmdPATH, which doesn't occur on Windows. It doesn't look in%PATH%, so we should ignore it on Windows.