[Mac] Use the new JdkInfo to fetch the Java SDK path and fix validation #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per the OpenJDK spec, GetJavaSdkPath() now follows these steps when fetching the SDK path: 1. Gets the prefered SDK path from ~/.config/xbuild/monodroid-config.xml 2. Checks $JAVA_HOME 3. Checks the output of /usr/libexec/java_home 4. ** NOT IMPLEMENTED YET **: Checks /etc/alternatives/java 5. A directory in $PATH that contains jarsigner Fixes VSTS #652760 and VSTS #646086
Contributor
Author
|
|
Contributor
Contributor
|
build |
Contributor
|
This PR should be updated to include the one-liner above. |
bratsche
changed the title
bratsche
changed the title
jonpryor
pushed a commit
that referenced
this pull request
Aug 2, 2018
Fixes: http://work.devdiv.io/646086 Fixes: http://work.devdiv.io/652760 Context: https://paper.dropbox.com/doc/OpenJDK-and-You--AH1yWKdVXgno~uXYfmcUAZTwAg-NoECAe2XkBQeoxFfGL6ea Update `AndroidSdkInfo.JavaSdkPath` so that it now uses `JdkInfo.GetKnownSystemJdkInfos()` to determine the JDK path to use, instead of separately reading from `monodroid-config.xml` or probing `$PATH` for `jarsigner`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use JdkInfo to get the Java SDK path, and fix Java SDK validation to work with OpenJDK.
Fixes VSTS #652760 and VSTS #646086