-
Notifications
You must be signed in to change notification settings - Fork 317
Disable incompatible tests on managed instance #3678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR disables tests that are incompatible with Azure SQL Managed Instance testing due to unsupported features and missing permissions. The changes ensure tests only run on environments where the required capabilities are available.
Key changes:
- Adds a new utility method
IsNotManagedInstance()to detect managed instance environments - Disables Vector and JSON tests on managed instances since these features are not yet supported
- Disables connection resiliency, MARS, distributed transaction, and XEvent tracing tests due to missing required permissions
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| DataTestUtility.cs | Adds IsNotManagedInstance() utility method for test filtering |
| XEventsTracingTest.cs | Disables XEvent tracing test on managed instances |
| VectorTypeBackwardCompatibilityTests.cs | Disables all vector backward compatibility tests on managed instances |
| NativeVectorFloat32Tests.cs | Disables all native vector tests on managed instances |
| DistributedTransactionTest.Windows.cs | Disables distributed transaction test with detailed comment explaining the issue |
| MARSSessionPoolingTest.cs | Disables all MARS session pooling tests on managed instances |
| JsonTest.cs | Disables all JSON feature tests on managed instances |
| JsonStreamTest.cs | Disables JSON streaming tests on managed instances |
| JsonBulkCopyTest.cs | Disables JSON bulk copy tests on managed instances |
| ConnectivityTest.cs | Disables connection resiliency SPID test on managed instances |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3678 +/- ##
==========================================
+ Coverage 77.40% 77.41% +0.01%
==========================================
Files 273 274 +1
Lines 46059 45564 -495
==========================================
- Hits 35651 35275 -376
+ Misses 10408 10289 -119
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
Disables tests that require capabilities that are not available or configured for the managed instance tests.
Azure SQL Managed Instances are available via "Azure" endpoints, yet run on the latest stable version of SQL Server (currently 2022). Certain features that are only available on Azure SQL such as JSON and Vector need to be skipped until managed instance transitions to SQL Server 2025.
Other tests rely on permissions that currently are not available to the MI test user. Those will be re-enabled later as those permissions are added and verified. https://sqlclientdrivers.visualstudio.com/ADO.Net/_workitems/edit/38472
Unsupported:
Missing permissions:
ALTER ANY CONNECTIONpermission to the userVIEW SERVER PERFORMANCE STATEpermission to the userALTER ANY CONNECTIONpermission to the userVIEW SERVER PERFORMANCE STATEpermission to the user