Skip to content

Conversation

@mdaigle
Copy link
Contributor

@mdaigle mdaigle commented Oct 9, 2025

Description

Disables tests that require capabilities that are not available or configured for the managed instance tests.
Azure SQL Managed Instances are available via "Azure" endpoints, yet run on the latest stable version of SQL Server (currently 2022). Certain features that are only available on Azure SQL such as JSON and Vector need to be skipped until managed instance transitions to SQL Server 2025.

Other tests rely on permissions that currently are not available to the MI test user. Those will be re-enabled later as those permissions are added and verified. https://sqlclientdrivers.visualstudio.com/ADO.Net/_workitems/edit/38472

Unsupported:

  • JSON tests
    • JSON not supported
  • Vector tests
    • Vector not supported

Missing permissions:

  • ConnectionResiliencySPIDTest
    • Need to grant the ALTER ANY CONNECTION permission to the user
  • MARS tests
    • Need to grant the VIEW SERVER PERFORMANCE STATE permission to the user
  • DistributedTransactionTest
    • Need to grant the ALTER ANY CONNECTION permission to the user
  • XEvent Tracing tests
    • Need to grant the VIEW SERVER PERFORMANCE STATE permission to the user

@paulmedynski paulmedynski self-assigned this Oct 10, 2025
@mdaigle mdaigle marked this pull request as ready for review October 13, 2025 18:49
@mdaigle mdaigle requested a review from a team as a code owner October 13, 2025 18:49
Copilot AI review requested due to automatic review settings October 13, 2025 18:49
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR disables tests that are incompatible with Azure SQL Managed Instance testing due to unsupported features and missing permissions. The changes ensure tests only run on environments where the required capabilities are available.

Key changes:

  • Adds a new utility method IsNotManagedInstance() to detect managed instance environments
  • Disables Vector and JSON tests on managed instances since these features are not yet supported
  • Disables connection resiliency, MARS, distributed transaction, and XEvent tracing tests due to missing required permissions

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.

Show a summary per file
File Description
DataTestUtility.cs Adds IsNotManagedInstance() utility method for test filtering
XEventsTracingTest.cs Disables XEvent tracing test on managed instances
VectorTypeBackwardCompatibilityTests.cs Disables all vector backward compatibility tests on managed instances
NativeVectorFloat32Tests.cs Disables all native vector tests on managed instances
DistributedTransactionTest.Windows.cs Disables distributed transaction test with detailed comment explaining the issue
MARSSessionPoolingTest.cs Disables all MARS session pooling tests on managed instances
JsonTest.cs Disables all JSON feature tests on managed instances
JsonStreamTest.cs Disables JSON streaming tests on managed instances
JsonBulkCopyTest.cs Disables JSON bulk copy tests on managed instances
ConnectivityTest.cs Disables connection resiliency SPID test on managed instances

@codecov
Copy link

codecov bot commented Oct 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.41%. Comparing base (c2554ad) to head (ace89dc).
⚠️ Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3678      +/-   ##
==========================================
+ Coverage   77.40%   77.41%   +0.01%     
==========================================
  Files         273      274       +1     
  Lines       46059    45564     -495     
==========================================
- Hits        35651    35275     -376     
+ Misses      10408    10289     -119     
Flag Coverage Δ
addons 90.82% <ø> (ø)
netcore 77.33% <ø> (+0.09%) ⬆️
netfx 76.56% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mdaigle mdaigle merged commit 127ec7b into main Oct 14, 2025
252 checks passed
@mdaigle mdaigle deleted the dev/cheena/disable-cr-test-on-managed-instance branch October 14, 2025 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants