Simplify diagnostic tracing #1193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cheenamalhotra
added
the
Code Health 💊
Wraith2
force-pushed
the
simplify-diagnostics
branch
from
cbeda93 to
147a2d7
Compare
Wraith2
commented
Aug 28, 2021
| { | ||
| _diagnosticListener.WriteCommandAfter(operationId, this, _transaction); | ||
| } | ||
| WriteEndExecuteEvent(success, sqlExceptionNumber, synchronous: true); |
Contributor
Author
There was a problem hiding this comment.
The original code wasn't setting success or reporting the end execute event, so i added them for symmetry with ExecuteScalar and EcecuteReader.
Wraith2
force-pushed
the
simplify-diagnostics
branch
from
147a2d7 to
2b885b0
Compare
Contributor
Author
|
@cheenamalhotra can i get some reviews on this please. I'd like to clear my backlog. |
...Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SqlClientDiagnosticListenerExtensions.cs
Outdated
Show resolved
Hide resolved
| } | ||
| } | ||
|
|
||
| internal ref struct DiagnosticScope //: IDisposable //ref structs cannot implement interfaces but the compiler will use pattern matching |
...Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SqlClientDiagnosticListenerExtensions.cs
Outdated
Show resolved
Hide resolved
Wraith2
force-pushed
the
simplify-diagnostics
branch
from
2b885b0 to
81a21a8
Compare
DavoudEshtehari
approved these changes
Oct 13, 2021
cheenamalhotra
approved these changes
Oct 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds scopes for diagnostic tracing and uses them where appropriate in sync methods. Async methods and ConnectionClose still need to do direct api calls to prevent the heap allocation of the scope data and because the close notifications can be conditional.