Only trace the event if tracing is enabled (should've read the comments)

benrr101 · benrr101 · commit 3560027976cc · 2025-11-04T13:56:19.000-06:00
diff --git a/src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/Utilities/AsyncHelper.cs b/src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/Utilities/AsyncHelper.cs
@@ -766,7 +766,7 @@ private static void ObserveContinuationException(Task continuationTask)
             continuationTask.ContinueWith(
                 static task =>
                 {
-                    SqlClientEventSource.Log.TraceEvent($"Unobserved task exception: {task.Exception}");
+                    SqlClientEventSource.Log.TryTraceEvent($"Unobserved task exception: {task.Exception}");
                     return _ = task.Exception;
                 },
                 TaskContinuationOptions.OnlyOnFaulted | TaskContinuationOptions.ExecuteSynchronously);

Original file line number	Diff line number	Diff line change
`@@ -766,7 +766,7 @@ private static void ObserveContinuationException(Task continuationTask)`
`766`	`766`	`continuationTask.ContinueWith(`
`767`	`767`	`static task =>`
`768`	`768`	`{`
`769`		`- SqlClientEventSource.Log.TraceEvent($"Unobserved task exception: {task.Exception}");`
	`769`	`+ SqlClientEventSource.Log.TryTraceEvent($"Unobserved task exception: {task.Exception}");`
`770`	`770`	`return _ = task.Exception;`
`771`	`771`	`},`
`772`	`772`	`TaskContinuationOptions.OnlyOnFaulted \| TaskContinuationOptions.ExecuteSynchronously);`