nbgv tool doesn't support Central Package Management

[na1307]

nbgv doesn't recognize Directory.Packages.props and CPM.

[KalleOlaviNiemitalo]

In what way would you want nbgv to recognise those? AFAIK it does not care about NuGet package references at all, so I don't see how the versions of the packages could matter.

[na1307]

If Directory.Packages.Props is detected and ManagePackageVersionsCentrally is set to true, package versions should be stored in Directory.Packages.Props instead. It is currently 1 am in the UTC+9 time zone where I am active. So I'll write more details after I sleep.

…

________________________________ From: Kalle Olavi Niemitalo ***@***.***> Sent: Wednesday, February 21, 2024 12:43:31 AM To: dotnet/Nerdbank.GitVersioning ***@***.***> Cc: na1307 ***@***.***>; Author ***@***.***> Subject: Re: [dotnet/Nerdbank.GitVersioning] nbgv tool doesn't support Central Package Management (Issue #1031) In what way would you want nbgv to recognise those? AFAIK it does not care about NuGet package references at all, so I don't see how the versions of the packages could matter. — Reply to this email directly, view it on GitHub<#1031 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AYYANHL36HYI45GNT2CAJWDYUTACHAVCNFSM6AAAAABDRBR4AKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJUGQ4TMMZZHE>. You are receiving this because you authored the thread.Message ID: ***@***.***>

[KalleOlaviNiemitalo]

Oh, I see nbgv install adds <PackageReference Include="Nerdbank.GitVersioning" PrivateAssets="all" Version="…" />. Is that the subcommand that should support CPM?

[AArnott]

I suspect that's what they're going for, yes. And I use CPM everywhere -- but I don't often use nbgv install, so this slipped my notice.

[na1307]

According to the documentation, the version must be omitted in the Build file and PackageVersion must be defined in the Packages file. For example:

Directory.Packages.props:

<Project>
  <PropertyGroup>
    <ManagePackageVersionsCentrally>true</ManagePackageVersionsCentrally>
  </PropertyGroup>
  <ItemGroup>
    <PackageVersion Include="Nerdbank.GitVersioning" Version="3.6.133" />
  </ItemGroup>
</Project>

Directory.Build.props:

<Project>
  <ItemGroup>
    <PackageReference Include="Nerdbank.GitVersioning" Condition="!Exists('packages.config')">
      <PrivateAssets>all</PrivateAssets>
    </PackageReference>
  </ItemGroup>
</Project>

[Tjeerd-menno]

Just add it as a GlobalPackageReference int the Directory.Package.props file. That way there's no need to add anything to the Directory.Build.props.

This is what I use.