Skip to content

3.8: use core definition import property #429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
michaelklishin opened this issue Aug 12, 2020 · 0 comments · Fixed by #430
Closed

3.8: use core definition import property #429

michaelklishin opened this issue Aug 12, 2020 · 0 comments · Fixed by #430

Comments

@michaelklishin
Copy link
Collaborator

michaelklishin commented Aug 12, 2020

This image still relies on the legacy management.load_definitions configuration key instead of a newer load_definitions.

These may seem identical but there are some differences:

  • The latter option does not require the management plugin to be enabled
  • The latter option is built into the node boot process and can happen e.g. after all plugins haven been activated.
    The is not the case for management.load_definition which, as any plugin initialization step, can happen only at plugin activation time.

The second point above means that any plugins that are enabled after the management plugin would not be available and their definitions would not pass validation and would be skipped.

Generating a config line that uses load_definitions instead of management.load_definitions should be all there is to do for this image. I'd be happy to contribute a PR after testing this change.

See rabbitmq/rabbitmq-server#2428 for the background.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant