From 32fbd9ed66e0e53ba58500fdc9758d30565275f5 Mon Sep 17 00:00:00 2001 From: Tim Schilling Date: Thu, 14 Aug 2025 13:17:45 +0300 Subject: [PATCH] Removed logging about the toolbar failing to serialize a value into JSON. --- debug_toolbar/store.py | 4 ---- docs/changes.rst | 5 +++++ tests/test_store.py | 6 ++++++ 3 files changed, 11 insertions(+), 4 deletions(-) diff --git a/debug_toolbar/store.py b/debug_toolbar/store.py index 76526fcff..02a2a0f72 100644 --- a/debug_toolbar/store.py +++ b/debug_toolbar/store.py @@ -1,6 +1,5 @@ import contextlib import json -import logging from collections import defaultdict, deque from collections.abc import Iterable from typing import Any @@ -13,15 +12,12 @@ from debug_toolbar import settings as dt_settings from debug_toolbar.models import HistoryEntry -logger = logging.getLogger(__name__) - class DebugToolbarJSONEncoder(DjangoJSONEncoder): def default(self, o): try: return super().default(o) except (TypeError, ValueError): - logger.debug("The debug toolbar can't serialize %s into JSON" % o) return force_str(o) diff --git a/docs/changes.rst b/docs/changes.rst index 5c7c0844b..47d0be615 100644 --- a/docs/changes.rst +++ b/docs/changes.rst @@ -1,6 +1,11 @@ Change log ========== +Pending +------- + +* Removed logging about the toolbar failing to serialize a value into JSON. + 6.0.0 (2025-07-22) ------------------ diff --git a/tests/test_store.py b/tests/test_store.py index db70377c9..e2425b4e8 100644 --- a/tests/test_store.py +++ b/tests/test_store.py @@ -14,6 +14,12 @@ def test_serialize(self): '{"hello": {"foo": "bar"}}', ) + def test_serialize_logs_on_failure(self): + self.assertEqual( + store.serialize({"hello": {"foo": b"bar"}}), + '{"hello": {"foo": "bar"}}', + ) + def test_deserialize(self): self.assertEqual( store.deserialize('{"hello": {"foo": "bar"}}'),