Specify version number of the dashboard in footer #3447
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specify version number Include the version number in the footer
dbutenhof
previously approved these changes
Jun 2, 2023
Member
dbutenhof
left a comment
dbutenhof
left a comment
There was a problem hiding this comment.
Thanks, Varshini!
I have a few comments and suggestions, but I don't have any objection to getting this in and moving along!
Member
|
This PR is crucial from testing perspective with this changes in one can report issues for particular dashboard version. |
dbutenhof
approved these changes
Jun 2, 2023
Member
dbutenhof
left a comment
dbutenhof
left a comment
There was a problem hiding this comment.
This PR is crucial from testing perspective with this changes in one can report issues for particular dashboard version.
There are two parts here: this change exposes the server version, which is only very loosely tied to the dashboard version. Right now the dashboard source code and build procedure don't have a concept of "dashboard version" but, if/when we had it, we could expose it along with the server version here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PBENCH-1092
Specify version number of the dashboard in the footer
Include the version number in the footer