Skip to content

test.pl now reports both directory and descriptor file name #8252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

kroening
Copy link
Member

The test.pl script identifies tests by the directory and the name of the descriptor file name. Historically, the directory was sufficient, since the descriptor file name used to be hardwired to test.desc. This changes the output to include both the path and the name of the file, which removes the need to look for directory and file name in two different places.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@kroening kroening added the Tests label Mar 24, 2024
The test.pl script identifies tests by the directory and the name of the
descriptor file name.  Historically, the directory was sufficient, since the
descriptor file name used to be hardwired to test.desc.  This changes the
output to include both the path and the name of the file, which removes the
need to look for directory and file name in two different places.
@kroening kroening force-pushed the test-pl-failed-test branch from 07648b1 to 8d2081a Compare March 24, 2024 14:56
Copy link

codecov bot commented Mar 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.64%. Comparing base (e8ff03a) to head (8d2081a).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #8252   +/-   ##
========================================
  Coverage    79.64%   79.64%           
========================================
  Files         1684     1684           
  Lines       195684   195684           
========================================
  Hits        155852   155852           
  Misses       39832    39832           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kroening kroening marked this pull request as ready for review March 24, 2024 15:43
@tautschnig tautschnig merged commit 08b2f2f into develop Mar 25, 2024
@tautschnig tautschnig deleted the test-pl-failed-test branch March 25, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants