Skip to content

Simplify NULL + 1 == NULL to false #7243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 17, 2022

Conversation

tautschnig
Copy link
Collaborator

This expression appears to arise in Rust's MIR when iterating over slices. See model-checking/kani#1767 for an example.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

This expression appears to arise in Rust's MIR when iterating over
slices. See model-checking/kani#1767 for an
example.
@tautschnig tautschnig added aws Bugs or features of importance to AWS CBMC users Kani Bugs or features of importance to Kani Rust Verifier labels Oct 14, 2022
@tautschnig tautschnig self-assigned this Oct 14, 2022
@codecov
Copy link

codecov bot commented Oct 14, 2022

Codecov Report

Base: 77.99% // Head: 77.99% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (9d51ea2) compared to base (99ce20c).
Patch coverage: 80.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #7243   +/-   ##
========================================
  Coverage    77.99%   77.99%           
========================================
  Files         1619     1619           
  Lines       187184   187194   +10     
========================================
+ Hits        145999   146007    +8     
- Misses       41185    41187    +2     
Impacted Files Coverage Δ
src/util/simplify_expr_int.cpp 85.53% <80.00%> (-0.06%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@peterschrammel peterschrammel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A regression test would still be great.

@tautschnig
Copy link
Collaborator Author

The CSmith test generated with random seed "1665747314" is failing for it produces too many objects. (locally) increasing the number of object bits results a verification failure, which is reproducible also with current develop. I will investigate separately.

@tautschnig tautschnig merged commit f286ec9 into diffblue:develop Oct 17, 2022
@tautschnig tautschnig deleted the feature/null-simp branch October 17, 2022 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aws Bugs or features of importance to AWS CBMC users Kani Bugs or features of importance to Kani Rust Verifier
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants