From ff9082a30f097de45b9a3b3114821ffbe1877730 Mon Sep 17 00:00:00 2001 From: Thomas Spriggs Date: Mon, 8 Nov 2021 14:44:14 +0000 Subject: [PATCH 1/3] Remove `@tautschnig` from code ownership of `/src/solvers/smt2` As requested by Michael Tautschnig in a review comment - https://github.com/diffblue/cbmc/pull/6422/files#r740281493 --- CODEOWNERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CODEOWNERS b/CODEOWNERS index 0d1c241a717..51913364017 100644 --- a/CODEOWNERS +++ b/CODEOWNERS @@ -54,7 +54,7 @@ /jbmc/src/janalyzer/ @peterschrammel @romainbrenguier /jbmc/src/jdiff/ @peterschrammel /src/cpp/ @kroening @tautschnig @peterschrammel -/src/solvers/smt2 @kroening @martin-cs @tautschnig @peterschrammel @allredj @romainbrenguier +/src/solvers/smt2 @kroening @martin-cs @peterschrammel @allredj @romainbrenguier /src/solvers/smt2_incremental @peterschrammel @thomasspriggs @NlightNFotis @TGWDB @chrisr-diffblue /src/statement-list/ @kroening @tautschnig @peterschrammel @pkesseli From 73e271ed2236f2ee68578afb16ff8d711dfa4af9 Mon Sep 17 00:00:00 2001 From: Thomas Spriggs Date: Mon, 8 Nov 2021 14:48:14 +0000 Subject: [PATCH 2/3] Update codeowners of `/src/solvers/smt2` to those working on it Removing @allredj @romainbrenguier as these people do not currently work on SMT2 support. Adding @thomasspriggs @NlightNFotis @TGWDB due to current experience of working on SMT2 support. --- CODEOWNERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CODEOWNERS b/CODEOWNERS index 51913364017..95fc892d680 100644 --- a/CODEOWNERS +++ b/CODEOWNERS @@ -54,7 +54,7 @@ /jbmc/src/janalyzer/ @peterschrammel @romainbrenguier /jbmc/src/jdiff/ @peterschrammel /src/cpp/ @kroening @tautschnig @peterschrammel -/src/solvers/smt2 @kroening @martin-cs @peterschrammel @allredj @romainbrenguier +/src/solvers/smt2 @kroening @martin-cs @peterschrammel @thomasspriggs @NlightNFotis @TGWDB /src/solvers/smt2_incremental @peterschrammel @thomasspriggs @NlightNFotis @TGWDB @chrisr-diffblue /src/statement-list/ @kroening @tautschnig @peterschrammel @pkesseli From a2299424417136dff2349546c0d6ce12f51d81fd Mon Sep 17 00:00:00 2001 From: Thomas Spriggs Date: Mon, 8 Nov 2021 15:01:41 +0000 Subject: [PATCH 3/3] Add codeowners of `/src/solvers/makefile` So that those who can approve changes to the smt2 solver support can also approve adding / removing / renaming `.cpp` files in those subdirectories. The list of codeowners is based on the global code owners plus the smt2 code owners. This is as suggested by Michael Tautschnig here - https://github.com/diffblue/cbmc/pull/6415#issuecomment-951813494 --- CODEOWNERS | 1 + 1 file changed, 1 insertion(+) diff --git a/CODEOWNERS b/CODEOWNERS index 95fc892d680..04cdb2a02ea 100644 --- a/CODEOWNERS +++ b/CODEOWNERS @@ -56,6 +56,7 @@ /src/cpp/ @kroening @tautschnig @peterschrammel /src/solvers/smt2 @kroening @martin-cs @peterschrammel @thomasspriggs @NlightNFotis @TGWDB /src/solvers/smt2_incremental @peterschrammel @thomasspriggs @NlightNFotis @TGWDB @chrisr-diffblue +/src/solvers/makefile @kroening @tautschnig @peterschrammel @chrisr-diffblue @thomasspriggs @NlightNFotis @TGWDB /src/statement-list/ @kroening @tautschnig @peterschrammel @pkesseli /cmake/ @diffblue/diffblue-opensource