diff --git a/regression/goto-instrument-wmm-core/ppc_aclwdrr005_POWER_ALL/test.desc b/regression/goto-instrument-wmm-core/ppc_aclwdrr005_POWER_ALL/test.desc index b4c228b9010..d8a21302ecf 100644 --- a/regression/goto-instrument-wmm-core/ppc_aclwdrr005_POWER_ALL/test.desc +++ b/regression/goto-instrument-wmm-core/ppc_aclwdrr005_POWER_ALL/test.desc @@ -1,4 +1,4 @@ -KNOWNBUG +CORE aclwdrr005.c POWER ALL ^EXIT=0$ diff --git a/regression/goto-instrument-wmm-core/ppc_aclwdrr005_POWER_OPC/test.desc b/regression/goto-instrument-wmm-core/ppc_aclwdrr005_POWER_OPC/test.desc index 2f9f05f1c50..c4124ae4d57 100644 --- a/regression/goto-instrument-wmm-core/ppc_aclwdrr005_POWER_OPC/test.desc +++ b/regression/goto-instrument-wmm-core/ppc_aclwdrr005_POWER_OPC/test.desc @@ -1,4 +1,4 @@ -KNOWNBUG +CORE aclwdrr005.c POWER OPC ^EXIT=0$ diff --git a/regression/goto-instrument-wmm-core/ppc_aclwdrr015_POWER_ALL/test.desc b/regression/goto-instrument-wmm-core/ppc_aclwdrr015_POWER_ALL/test.desc index eac61a892ec..11edafd0dcf 100644 --- a/regression/goto-instrument-wmm-core/ppc_aclwdrr015_POWER_ALL/test.desc +++ b/regression/goto-instrument-wmm-core/ppc_aclwdrr015_POWER_ALL/test.desc @@ -1,4 +1,4 @@ -KNOWNBUG +THOROUGH aclwdrr015.c POWER ALL ^EXIT=10$ diff --git a/regression/goto-instrument-wmm-core/ppc_aclwdrr015_POWER_OPC/test.desc b/regression/goto-instrument-wmm-core/ppc_aclwdrr015_POWER_OPC/test.desc index 46eac8210e1..7e68b7a0a30 100644 --- a/regression/goto-instrument-wmm-core/ppc_aclwdrr015_POWER_OPC/test.desc +++ b/regression/goto-instrument-wmm-core/ppc_aclwdrr015_POWER_OPC/test.desc @@ -1,4 +1,4 @@ -KNOWNBUG +THOROUGH aclwdrr015.c POWER OPC ^EXIT=10$ diff --git a/regression/goto-instrument-wmm-core/ppc_aclwsrr000_RMO_ALL/test.desc b/regression/goto-instrument-wmm-core/ppc_aclwsrr000_RMO_ALL/test.desc index fc44a1bd08a..18b30878edb 100644 --- a/regression/goto-instrument-wmm-core/ppc_aclwsrr000_RMO_ALL/test.desc +++ b/regression/goto-instrument-wmm-core/ppc_aclwsrr000_RMO_ALL/test.desc @@ -1,4 +1,4 @@ -KNOWNBUG +THOROUGH aclwsrr000.c RMO ALL ^EXIT=0$ diff --git a/regression/goto-instrument-wmm-core/ppc_aclwsrr000_RMO_OPC/test.desc b/regression/goto-instrument-wmm-core/ppc_aclwsrr000_RMO_OPC/test.desc index ed83175c808..f9addb815e2 100644 --- a/regression/goto-instrument-wmm-core/ppc_aclwsrr000_RMO_OPC/test.desc +++ b/regression/goto-instrument-wmm-core/ppc_aclwsrr000_RMO_OPC/test.desc @@ -1,4 +1,4 @@ -KNOWNBUG +THOROUGH aclwsrr000.c RMO OPC ^EXIT=0$ diff --git a/regression/goto-instrument-wmm-core/ppc_aclwsrr002_POWER_ALL/test.desc b/regression/goto-instrument-wmm-core/ppc_aclwsrr002_POWER_ALL/test.desc index 19024d01163..f6ea5dceee4 100644 --- a/regression/goto-instrument-wmm-core/ppc_aclwsrr002_POWER_ALL/test.desc +++ b/regression/goto-instrument-wmm-core/ppc_aclwsrr002_POWER_ALL/test.desc @@ -1,4 +1,4 @@ -KNOWNBUG +THOROUGH aclwsrr002.c POWER ALL ^EXIT=0$ diff --git a/regression/goto-instrument-wmm-core/ppc_aclwsrr002_POWER_OPC/test.desc b/regression/goto-instrument-wmm-core/ppc_aclwsrr002_POWER_OPC/test.desc index 1b1bb7b3dc1..c81e6325045 100644 --- a/regression/goto-instrument-wmm-core/ppc_aclwsrr002_POWER_OPC/test.desc +++ b/regression/goto-instrument-wmm-core/ppc_aclwsrr002_POWER_OPC/test.desc @@ -1,4 +1,4 @@ -KNOWNBUG +THOROUGH aclwsrr002.c POWER OPC ^EXIT=0$ diff --git a/regression/goto-instrument-wmm-core/ppc_aclwsrr002_RMO_ALL/test.desc b/regression/goto-instrument-wmm-core/ppc_aclwsrr002_RMO_ALL/test.desc index bfb72b0a88e..d54330a9ac7 100644 --- a/regression/goto-instrument-wmm-core/ppc_aclwsrr002_RMO_ALL/test.desc +++ b/regression/goto-instrument-wmm-core/ppc_aclwsrr002_RMO_ALL/test.desc @@ -1,4 +1,4 @@ -KNOWNBUG +THOROUGH aclwsrr002.c RMO ALL ^EXIT=0$ diff --git a/regression/goto-instrument-wmm-core/ppc_aclwsrr002_RMO_OPC/test.desc b/regression/goto-instrument-wmm-core/ppc_aclwsrr002_RMO_OPC/test.desc index 3abd1175269..7139f8e4b71 100644 --- a/regression/goto-instrument-wmm-core/ppc_aclwsrr002_RMO_OPC/test.desc +++ b/regression/goto-instrument-wmm-core/ppc_aclwsrr002_RMO_OPC/test.desc @@ -1,4 +1,4 @@ -KNOWNBUG +THOROUGH aclwsrr002.c RMO OPC ^EXIT=0$ diff --git a/regression/goto-instrument-wmm-core/ppc_safe004_POWER_OPC/test.desc b/regression/goto-instrument-wmm-core/ppc_safe004_POWER_OPC/test.desc index 9c68bf2ded2..53472b25006 100644 --- a/regression/goto-instrument-wmm-core/ppc_safe004_POWER_OPC/test.desc +++ b/regression/goto-instrument-wmm-core/ppc_safe004_POWER_OPC/test.desc @@ -1,4 +1,4 @@ -KNOWNBUG +THOROUGH safe004.c POWER OPC ^EXIT=0$ diff --git a/src/goto-instrument/wmm/shared_buffers.cpp b/src/goto-instrument/wmm/shared_buffers.cpp index 928417c9485..2bd2510bd67 100644 --- a/src/goto-instrument/wmm/shared_buffers.cpp +++ b/src/goto-instrument/wmm/shared_buffers.cpp @@ -41,41 +41,25 @@ const shared_bufferst::varst &shared_bufferst::operator()( vars.type=symbol.type; - vars.w_buff0=add(object, symbol.base_name, "$w_buff0", symbol.type); - vars.w_buff1=add(object, symbol.base_name, "$w_buff1", symbol.type); + vars.w_buff0 = add(symbol, "$w_buff0", symbol.type); + vars.w_buff1 = add(symbol, "$w_buff1", symbol.type); - vars.w_buff0_used=add(object, symbol.base_name, "$w_buff0_used", - bool_typet()); - vars.w_buff1_used=add(object, symbol.base_name, "$w_buff1_used", - bool_typet()); + vars.w_buff0_used = add(symbol, "$w_buff0_used", bool_typet()); + vars.w_buff1_used = add(symbol, "$w_buff1_used", bool_typet()); - vars.mem_tmp=add(object, symbol.base_name, "$mem_tmp", symbol.type); - vars.flush_delayed=add(object, symbol.base_name, "$flush_delayed", - bool_typet()); + vars.mem_tmp = add(symbol, "$mem_tmp", symbol.type); + vars.flush_delayed = add(symbol, "$flush_delayed", bool_typet()); - vars.read_delayed= - add(object, symbol.base_name, "$read_delayed", bool_typet()); - vars.read_delayed_var= - add( - object, - symbol.base_name, - "$read_delayed_var", - pointer_type(symbol.type)); + vars.read_delayed = add(symbol, "$read_delayed", bool_typet()); + vars.read_delayed_var = + add(symbol, "$read_delayed_var", pointer_type(symbol.type)); for(unsigned cnt=0; cntbase_name) - : "main"; - return add(function_base_name+"_weak_choice", - function_base_name+"_weak_choice", suffix, bool_typet()); + CHECK_RETURN(maybe_symbol); + return add(*maybe_symbol, "_weak_choice" + suffix, bool_typet()); } bool is_buffered( @@ -244,29 +240,24 @@ class shared_bufferst messaget &message; irep_idt add( - const irep_idt &object, - const irep_idt &base_name, + const symbolt &object, const std::string &suffix, const typet &type, bool added_as_instrumentation); - irep_idt add( - const irep_idt &object, - const irep_idt &base_name, - const std::string &suffix, - const typet &type) + irep_idt + add(const symbolt &object, const std::string &suffix, const typet &type) { - return add(object, base_name, suffix, type, true); + return add(object, suffix, type, true); } /* inserting a non-instrumenting, fresh variable */ irep_idt add_fresh_var( - const irep_idt &object, - const irep_idt &base_name, + const symbolt &object, const std::string &suffix, const typet &type) { - return add(object, base_name, suffix, type, false); + return add(object, suffix, type, false); } void add_initialization(goto_programt &goto_program);