From 1fe9701d399ccb63046e081b41d5e153ba415e79 Mon Sep 17 00:00:00 2001
From: Michael Tautschnig <tautschn@amazon.com>
Date: Fri, 9 Nov 2018 16:28:31 +0000
Subject: [PATCH] Rename parameters of div_and_round

This avoids shadowing the "fraction" class member and also uses the correct
mathematical terminology.
---
 src/util/ieee_float.cpp | 24 ++++++++++++------------
 src/util/ieee_float.h   |  2 +-
 2 files changed, 13 insertions(+), 13 deletions(-)

diff --git a/src/util/ieee_float.cpp b/src/util/ieee_float.cpp
index cb0b9835e07..ef475f1fa95 100644
--- a/src/util/ieee_float.cpp
+++ b/src/util/ieee_float.cpp
@@ -646,11 +646,11 @@ void ieee_floatt::align()
 }
 
 void ieee_floatt::divide_and_round(
-  mp_integer &fraction,
-  const mp_integer &factor)
+  mp_integer &dividend,
+  const mp_integer &divisor)
 {
-  mp_integer remainder=fraction%factor;
-  fraction/=factor;
+  const mp_integer remainder = dividend % divisor;
+  dividend /= divisor;
 
   if(remainder!=0)
   {
@@ -658,19 +658,19 @@ void ieee_floatt::divide_and_round(
     {
     case ROUND_TO_EVEN:
       {
-        mp_integer factor_middle=factor/2;
-        if(remainder<factor_middle)
+        mp_integer divisor_middle = divisor / 2;
+        if(remainder < divisor_middle)
         {
           // crop
         }
-        else if(remainder>factor_middle)
+        else if(remainder > divisor_middle)
         {
-          ++fraction;
+          ++dividend;
         }
         else // exactly in the middle -- go to even
         {
-          if((fraction%2)!=0)
-            ++fraction;
+          if((dividend % 2) != 0)
+            ++dividend;
         }
       }
       break;
@@ -681,12 +681,12 @@ void ieee_floatt::divide_and_round(
 
     case ROUND_TO_MINUS_INF:
       if(sign_flag)
-        ++fraction;
+        ++dividend;
       break;
 
     case ROUND_TO_PLUS_INF:
       if(!sign_flag)
-        ++fraction;
+        ++dividend;
       break;
 
     default:
diff --git a/src/util/ieee_float.h b/src/util/ieee_float.h
index 52ece8d191f..eb74064aed7 100644
--- a/src/util/ieee_float.h
+++ b/src/util/ieee_float.h
@@ -301,7 +301,7 @@ class ieee_floatt
   bool ieee_not_equal(const ieee_floatt &other) const;
 
 protected:
-  void divide_and_round(mp_integer &fraction, const mp_integer &factor);
+  void divide_and_round(mp_integer &dividend, const mp_integer &divisor);
   void align();
   void next_representable(bool greater);