From e5744b2f7ad5081e2c8a58f40b8b9ea577067c85 Mon Sep 17 00:00:00 2001 From: Chris Smowton Date: Tue, 24 Oct 2017 16:42:58 +0100 Subject: [PATCH 1/2] Reorder code owner definition according to change risk --- CODEOWNERS | 31 ++++++++++++++++--------------- 1 file changed, 16 insertions(+), 15 deletions(-) diff --git a/CODEOWNERS b/CODEOWNERS index abd237be8bc..4ee779617fa 100644 --- a/CODEOWNERS +++ b/CODEOWNERS @@ -1,36 +1,37 @@ # These owners will be the default owners for everything in the repo. * @kroening @tautschnig @peterschrammel -src/java_bytecode/ @smowton @mgudemann @cristina-david @jgwilson42 @pkesseli @Degiorgio @NathanJPhillips -src/jbmc/ @smowton @mgudemann @cristina-david @jgwilson42 @pkesseli @Degiorgio @NathanJPhillips -src/miniz/ @smowton @mgudemann @cristina-david @jgwilson42 @pkesseli +# These files should rarely change src/ansi-c/ @marek-trtik @kroening @tautschnig +src/linking/ @smowton @kroening @tautschnig @peterschrammel @marek-trtik +src/miniz/ @smowton @mgudemann @cristina-david @jgwilson42 @pkesseli -src/cpp/ @marek-trtik @kroening @tautschnig - -CMakeLists.txt @reuk @thk123 -cmake/ @reuk @thk123 +# These files change frequently and changes are high-risk +src/goto-programs/ @smowton @kroening @tautschnig @peterschrammel @marek-trtik src/solvers/ @martin-cs @romainbrenguier @antlechner @kroening - +src/java_bytecode/ @smowton @mgudemann @cristina-david @jgwilson42 @pkesseli @Degiorgio @NathanJPhillips src/analyses/ @martin-cs @peterschrammel @thk123 @marek-trtik @NathanJPhillips +src/pointer-analysis/ @martin-cs @peterschrammel @thk123 @marek-trtik -src/pointer-analysis/ @martin-cs @peterschrammel @thk123 @marek-trtik -src/goto-analyzer/ @martin-cs @peterschrammel @thk123 @marek-trtik +# These files change frequently and changes are medium-risk -src/goto-instrument/ @martin-cs @peterschrammel @thk123 @marek-trtik +src/goto-analyzer/ @martin-cs @peterschrammel @thk123 @marek-trtik +src/goto-instrument/ @martin-cs @peterschrammel @thk123 @marek-trtik +src/jbmc/ @smowton @mgudemann @cristina-david @jgwilson42 @pkesseli @Degiorgio @NathanJPhillips +src/cpp/ @marek-trtik @kroening @tautschnig -src/goto-programs/ @smowton @kroening @tautschnig @peterschrammel @marek-trtik -src/linking/ @smowton @kroening @tautschnig @peterschrammel @marek-trtik +# These files change frequently and changes are low-risk unit/ @diffblue/cbmc-developers - regression/ @diffblue/cbmc-developers +CMakeLists.txt @reuk @thk123 +cmake/ @reuk @thk123 + .travis.yml @diffblue/devops @thk123 @forejtv @jgwilson42 @rabiamarzhiya appveyor.yml @diffblue/devops @thk123 @forejtv @jgwilson42 @rabiamarzhiya - From 95cf5c346b2336b3ce44fc92c015a454239bdd33 Mon Sep 17 00:00:00 2001 From: Peter Schrammel Date: Fri, 3 Nov 2017 17:00:54 +0000 Subject: [PATCH 2/2] Add directories without code owners and adapt code owners --- CODEOWNERS | 54 +++++++++++++++++++++++++++++++++++++----------------- 1 file changed, 37 insertions(+), 17 deletions(-) diff --git a/CODEOWNERS b/CODEOWNERS index 4ee779617fa..7e602fd5af9 100644 --- a/CODEOWNERS +++ b/CODEOWNERS @@ -1,28 +1,47 @@ # These owners will be the default owners for everything in the repo. -* @kroening @tautschnig @peterschrammel +* @kroening @tautschnig @peterschrammel @smowton @chrisr-diffblue # These files should rarely change -src/ansi-c/ @marek-trtik @kroening @tautschnig -src/linking/ @smowton @kroening @tautschnig @peterschrammel @marek-trtik -src/miniz/ @smowton @mgudemann @cristina-david @jgwilson42 @pkesseli +src/big-int/ @kroening +src/ansi-c/ @kroening @tautschnig +src/assembler/ @kroening @tautschnig +src/goto-cc/ @kroening @tautschnig +src/linking/ @kroening @tautschnig +src/memory-models/ @kroening @tautschnig +src/goto-symex/ @kroening @tautschnig @peterschrammel +src/json/ @kroening @tautschnig @peterschrammel +src/langapi/ @kroening @tautschnig @peterschrammel +src/xmllang/ @kroening @tautschnig @peterschrammel +src/nonstd/ @smowton @peterschrammel +src/solvers/cvc @martin-cs @kroening +src/solvers/flattening @martin-cs @kroening @tautschnig @peterschrammel +src/solvers/floatbv @martin-cs @kroening +src/solvers/miniBDD @tautschnig @kroening +src/solvers/prop @martin-cs @kroening @tautschnig @peterschrammel +src/solvers/sat @martin-cs @kroening @tautschnig @peterschrammel +src/solvers/smt2 @martin-cs @tautschnig @peterschrammel +src/miniz/ @smowton @mgudemann @peterschrammel # These files change frequently and changes are high-risk -src/goto-programs/ @smowton @kroening @tautschnig @peterschrammel @marek-trtik -src/solvers/ @martin-cs @romainbrenguier @antlechner @kroening -src/java_bytecode/ @smowton @mgudemann @cristina-david @jgwilson42 @pkesseli @Degiorgio @NathanJPhillips -src/analyses/ @martin-cs @peterschrammel @thk123 @marek-trtik @NathanJPhillips -src/pointer-analysis/ @martin-cs @peterschrammel @thk123 @marek-trtik +src/cbmc/ @smowton @kroening @tautschnig @peterschrammel +src/goto-programs/ @smowton @kroening @tautschnig @peterschrammel @pkesseli +src/util/ @smowton @kroening @tautschnig @peterschrammel @pkesseli +src/solvers/refinement @martin-cs @romainbrenguier @peterschrammel +src/java_bytecode/ @smowton @mgudemann @thk123 @cristina-david @cesaro @pkesseli @NathanJPhillips @peterschrammel +src/analyses/ @martin-cs @peterschrammel @chrisr-diffblue @thk123 @smowton +src/pointer-analysis/ @martin-cs @peterschrammel @chrisr-diffblue @smowton # These files change frequently and changes are medium-risk -src/goto-analyzer/ @martin-cs @peterschrammel @thk123 @marek-trtik -src/goto-instrument/ @martin-cs @peterschrammel @thk123 @marek-trtik -src/jbmc/ @smowton @mgudemann @cristina-david @jgwilson42 @pkesseli @Degiorgio @NathanJPhillips -src/cpp/ @marek-trtik @kroening @tautschnig +src/goto-analyzer/ @martin-cs @chrisr-diffblue @peterschrammel +src/goto-instrument/ @martin-cs @chrisr-diffblue @peterschrammel +src/goto-diff/ @tautschnig @peterschrammel +src/jbmc/ @smowton @mgudemann @cristina-david @cesaro @pkesseli @peterschrammel +src/cpp/ @kroening @tautschnig @peterschrammel # These files change frequently and changes are low-risk @@ -30,8 +49,9 @@ src/cpp/ @marek-trtik @kroening @tautschnig unit/ @diffblue/cbmc-developers regression/ @diffblue/cbmc-developers -CMakeLists.txt @reuk @thk123 -cmake/ @reuk @thk123 +CMakeLists.txt @reuk @chrisr-diffblue +cmake/ @reuk @chrisr-diffblue -.travis.yml @diffblue/devops @thk123 @forejtv @jgwilson42 @rabiamarzhiya -appveyor.yml @diffblue/devops @thk123 @forejtv @jgwilson42 @rabiamarzhiya +scripts/ @diffblue/devops @thk123 @forejtv @peterschrammel +.travis.yml @diffblue/devops @thk123 @forejtv @peterschrammel +appveyor.yml @diffblue/devops @thk123 @forejtv @peterschrammel