use new messaging API in Java typechecker

Author: Daniel Kroening

src/java_bytecode/java_bytecode_typecheck.h

@@ -27,13 +27,13 @@ bool java_bytecode_typecheck(
   message_handlert &message_handler,
   const namespacet &ns);
 
-class java_bytecode_typecheckt:public legacy_typecheckt
+class java_bytecode_typecheckt:public typecheckt
 {
 public:
   java_bytecode_typecheckt(
     symbol_tablet &_symbol_table,
     message_handlert &_message_handler):
-    legacy_typecheckt(_message_handler),
+    typecheckt(_message_handler),
     symbol_table(_symbol_table),
     ns(symbol_table)
   {

src/java_bytecode/java_bytecode_typecheck_expr.cpp

@@ -191,14 +191,9 @@ void java_bytecode_typecheckt::typecheck_expr_member(member_exprt &expr)
     expr.struct_op()=m;
   }
 
-  #if 0
   warning().source_location=expr.source_location();
   warning() << "failed to find field `"
             << component_name << "` in class hierarchy" << eom;
-  #else
-  warning_msg("failed to find field `"+
-              id2string(component_name)+"` in class hierarchy");
-  #endif
 
   // We replace by a non-det of same type
   side_effect_expr_nondett nondet(expr.type());