Use s.clear() instead of s=""

tautschnig · tautschnig · commit 9aac51ddaf85 · 2019-03-21T08:53:45.000Z
This avoids string table lookups.
diff --git a/jbmc/unit/pointer-analysis/custom_value_set_analysis.cpp b/jbmc/unit/pointer-analysis/custom_value_set_analysis.cpp
@@ -171,7 +171,7 @@ SCENARIO("test_value_set_analysis",
   GIVEN("Normal and custom value-set analysis of CustomVSATest::test")
   {
     config.set_arch("none");
-    config.main = "";
+    config.main.clear();
 
     // This classpath is the default, but the config object
     // is global and previous unit tests may have altered it
diff --git a/src/ansi-c/expr2c.cpp b/src/ansi-c/expr2c.cpp
@@ -285,13 +285,13 @@ std::string expr2ct::convert_rec(
     if(width==config.ansi_c.int_width)
     {
       if(is_signed)
-        sign_str="";
+        sign_str.clear();
       return q+sign_str+"int"+d;
     }
     else if(width==config.ansi_c.long_int_width)
     {
       if(is_signed)
-        sign_str="";
+        sign_str.clear();
       return q+sign_str+"long int"+d;
     }
     else if(width==config.ansi_c.char_width)
@@ -302,19 +302,19 @@ std::string expr2ct::convert_rec(
     else if(width==config.ansi_c.short_int_width)
     {
       if(is_signed)
-        sign_str="";
+        sign_str.clear();
       return q+sign_str+"short int"+d;
     }
     else if(width==config.ansi_c.long_long_int_width)
     {
       if(is_signed)
-        sign_str="";
+        sign_str.clear();
       return q+sign_str+"long long int"+d;
     }
     else if(width==128)
     {
       if(is_signed)
-        sign_str="";
+        sign_str.clear();
       return q + sign_str + "__int128" + d;
     }
     else
diff --git a/src/cpp/cpp_name.cpp b/src/cpp/cpp_name.cpp
@@ -66,7 +66,7 @@ void cpp_namet::convert(
     identifier+=name_component;
 
     if(id=="::")
-      base_name="";
+      base_name.clear();
     else
       base_name+=name_component;
   }
diff --git a/src/cpp/cpp_token.h b/src/cpp/cpp_token.h
@@ -29,9 +29,9 @@ class cpp_tokent
   {
     kind=0;
     data.clear();
-    text="";
+    text.clear();
     line_no=0;
-    filename="";
+    filename.clear();
   }
 
   void swap(cpp_tokent &token)
diff --git a/src/cpp/cpp_typecheck_resolve.cpp b/src/cpp/cpp_typecheck_resolve.cpp
@@ -1277,7 +1277,7 @@ void cpp_typecheck_resolvet::show_identifiers(
       else if(id_expr.id() == ID_pod_constructor)
       {
         out << "constructor ";
-        id="";
+        id.clear();
       }
       else if(id_expr.id()==ID_template_function_instance)
       {
diff --git a/src/goto-cc/armcc_mode.cpp b/src/goto-cc/armcc_mode.cpp
@@ -129,7 +129,7 @@ int armcc_modet::doit()
   }
   else
   {
-    compiler.output_file_object="";
+    compiler.output_file_object.clear();
     compiler.output_file_executable="a.out";
   }
 
diff --git a/src/goto-cc/cw_mode.cpp b/src/goto-cc/cw_mode.cpp
@@ -94,7 +94,7 @@ int cw_modet::doit()
   }
   else
   {
-    compiler.output_file_object="";
+    compiler.output_file_object.clear();
     compiler.output_file_executable="a.out";
   }
 
diff --git a/src/goto-cc/gcc_mode.cpp b/src/goto-cc/gcc_mode.cpp
@@ -659,7 +659,7 @@ int gcc_modet::doit()
   }
   else
   {
-    compiler.output_file_object="";
+    compiler.output_file_object.clear();
     compiler.output_file_executable="a.out";
   }
 
@@ -721,14 +721,14 @@ int gcc_modet::doit()
         {
           language=arg_it->arg;
           if(language=="none")
-            language="";
+            language.clear();
         }
       }
       else if(has_prefix(arg_it->arg, "-x"))
       {
         language=std::string(arg_it->arg, 2, std::string::npos);
         if(language=="none")
-          language="";
+          language.clear();
       }
     }
   }
diff --git a/src/goto-cc/ld_mode.cpp b/src/goto-cc/ld_mode.cpp
@@ -123,7 +123,7 @@ int ld_modet::doit()
   }
   else
   {
-    compiler.output_file_object = "";
+    compiler.output_file_object.clear();
     compiler.output_file_executable = "a.out";
   }
 
diff --git a/src/goto-cc/ms_cl_cmdline.cpp b/src/goto-cc/ms_cl_cmdline.cpp
@@ -434,7 +434,7 @@ void ms_cl_cmdlinet::process_cl_option(const std::string &s)
       if(s.size()==2)
       {
         option.islong=false;
-        option.optstring="";
+        option.optstring.clear();
         option.optchar=s[1];
         optnr=getoptnr(option.optchar);
       }
@@ -470,7 +470,7 @@ void ms_cl_cmdlinet::process_cl_option(const std::string &s)
       if(ms_cl_prefix.size()==1)
       {
         option.islong=false;
-        option.optstring="";
+        option.optstring.clear();
         option.optchar=ms_cl_prefix[0];
         optnr=getoptnr(option.optchar);
       }
diff --git a/src/goto-instrument/dump_c.cpp b/src/goto-instrument/dump_c.cpp
@@ -452,7 +452,7 @@ void dump_ct::convert_compound(
     if(comp_type.id()==ID_c_bit_field &&
        to_c_bit_field_type(comp_type).get_width()==0)
     {
-      comp_name="";
+      comp_name.clear();
       s=type_to_string(comp_type);
     }
 
@@ -502,7 +502,7 @@ void dump_ct::convert_compound(
       typedef_map.insert({typedef_str, typedef_infot(typedef_str)});
     PRECONDITION(!td_map_entry.second);
     if(!td_map_entry.first->second.early)
-      td_map_entry.first->second.type_decl_str="";
+      td_map_entry.first->second.type_decl_str.clear();
     os << "typedef ";
   }
 
diff --git a/src/pointer-analysis/value_set.cpp b/src/pointer-analysis/value_set.cpp
@@ -107,12 +107,12 @@ void value_sett::output(
     if(has_prefix(id2string(e.identifier), "value_set::dynamic_object"))
     {
       display_name=id2string(e.identifier)+e.suffix;
-      identifier="";
+      identifier.clear();
     }
     else if(e.identifier=="value_set::return_value")
     {
       display_name="RETURN_VALUE"+e.suffix;
-      identifier="";
+      identifier.clear();
     }
     else
     {
diff --git a/src/pointer-analysis/value_set_fi.cpp b/src/pointer-analysis/value_set_fi.cpp
@@ -57,7 +57,7 @@ void value_set_fit::output(
     if(has_prefix(id2string(e.identifier), "value_set::dynamic_object"))
     {
       display_name=id2string(e.identifier)+e.suffix;
-      identifier="";
+      identifier.clear();
     }
     else
     {
diff --git a/src/util/cmdline.cpp b/src/util/cmdline.cpp
@@ -169,7 +169,7 @@ bool cmdlinet::parse(int argc, const char **argv, const char *optstring)
       option.islong=true;
       option.optchar=0;
       option.isset=false;
-      option.optstring="";
+      option.optstring.clear();
 
       for(optstring++; optstring[0]!=')' && optstring[0]!=0; optstring++)
         option.optstring+=optstring[0];
@@ -181,7 +181,7 @@ bool cmdlinet::parse(int argc, const char **argv, const char *optstring)
     {
       option.islong=false;
       option.optchar=optstring[0];
-      option.optstring="";
+      option.optstring.clear();
       option.isset=false;
 
       optstring++;
diff --git a/src/util/identifier.cpp b/src/util/identifier.cpp
@@ -43,6 +43,6 @@ void identifiert::parse(const std::string &s)
     }
 
     components.push_back(component);
-    component="";
+    component.clear();
   }
 }
diff --git a/src/util/lispexpr.cpp b/src/util/lispexpr.cpp
@@ -62,7 +62,7 @@ bool lispexprt::parse(
   std::string::size_type &ptr)
 {
   clear();
-  value="";
+  value.clear();
 
   if(ptr==std::string::npos || ptr>=s.size())
     return true;
@@ -156,7 +156,7 @@ int test_lispexpr()
 
   while(true)
   {
-    line="";
+    line.clear();
 
     while(true)
     {
diff --git a/src/util/lispirep.cpp b/src/util/lispirep.cpp
@@ -43,7 +43,7 @@ void lisp2irep(const lispexprt &src, irept &dest)
 void irep2lisp(const irept &src, lispexprt &dest)
 {
   dest.clear();
-  dest.value="";
+  dest.value.clear();
   dest.type=lispexprt::List;
 
 #ifdef NAMED_SUB_IS_FORWARD_LIST
@@ -65,7 +65,7 @@ void irep2lisp(const irept &src, lispexprt &dest)
   {
     lispexprt name;
     name.type=lispexprt::String;
-    name.value="";
+    name.value.clear();
     dest.push_back(name);
 
     lispexprt sub;

Original file line number	Diff line number	Diff line change
`@@ -171,7 +171,7 @@ SCENARIO("test_value_set_analysis",`
`171`	`171`	`GIVEN("Normal and custom value-set analysis of CustomVSATest::test")`
`172`	`172`	`{`
`173`	`173`	`config.set_arch("none");`
`174`		`- config.main = "";`
	`174`	`+ config.main.clear();`
`175`	`175`
`176`	`176`	`// This classpath is the default, but the config object`
`177`	`177`	`// is global and previous unit tests may have altered it`
Original file line number	Diff line number	Diff line change
`@@ -285,13 +285,13 @@ std::string expr2ct::convert_rec(`
`285`	`285`	`if(width==config.ansi_c.int_width)`
`286`	`286`	`{`
`287`	`287`	`if(is_signed)`
`288`		`- sign_str="";`
	`288`	`+ sign_str.clear();`
`289`	`289`	`return q+sign_str+"int"+d;`
`290`	`290`	`}`
`291`	`291`	`else if(width==config.ansi_c.long_int_width)`
`292`	`292`	`{`
`293`	`293`	`if(is_signed)`
`294`		`- sign_str="";`
	`294`	`+ sign_str.clear();`
`295`	`295`	`return q+sign_str+"long int"+d;`
`296`	`296`	`}`
`297`	`297`	`else if(width==config.ansi_c.char_width)`
`@@ -302,19 +302,19 @@ std::string expr2ct::convert_rec(`
`302`	`302`	`else if(width==config.ansi_c.short_int_width)`
`303`	`303`	`{`
`304`	`304`	`if(is_signed)`
`305`		`- sign_str="";`
	`305`	`+ sign_str.clear();`
`306`	`306`	`return q+sign_str+"short int"+d;`
`307`	`307`	`}`
`308`	`308`	`else if(width==config.ansi_c.long_long_int_width)`
`309`	`309`	`{`
`310`	`310`	`if(is_signed)`
`311`		`- sign_str="";`
	`311`	`+ sign_str.clear();`
`312`	`312`	`return q+sign_str+"long long int"+d;`
`313`	`313`	`}`
`314`	`314`	`else if(width==128)`
`315`	`315`	`{`
`316`	`316`	`if(is_signed)`
`317`		`- sign_str="";`
	`317`	`+ sign_str.clear();`
`318`	`318`	`return q + sign_str + "__int128" + d;`
`319`	`319`	`}`
`320`	`320`	`else`
Original file line number	Diff line number	Diff line change
`@@ -66,7 +66,7 @@ void cpp_namet::convert(`
`66`	`66`	`identifier+=name_component;`
`67`	`67`
`68`	`68`	`if(id=="::")`
`69`		`- base_name="";`
	`69`	`+ base_name.clear();`
`70`	`70`	`else`
`71`	`71`	`base_name+=name_component;`
`72`	`72`	`}`
Original file line number	Diff line number	Diff line change
`@@ -29,9 +29,9 @@ class cpp_tokent`
`29`	`29`	`{`
`30`	`30`	`kind=0;`
`31`	`31`	`data.clear();`
`32`		`- text="";`
	`32`	`+ text.clear();`
`33`	`33`	`line_no=0;`
`34`		`- filename="";`
	`34`	`+ filename.clear();`
`35`	`35`	`}`
`36`	`36`
`37`	`37`	`void swap(cpp_tokent &token)`
Original file line number	Diff line number	Diff line change
`@@ -1277,7 +1277,7 @@ void cpp_typecheck_resolvet::show_identifiers(`
`1277`	`1277`	`else if(id_expr.id() == ID_pod_constructor)`
`1278`	`1278`	`{`
`1279`	`1279`	`out << "constructor ";`
`1280`		`- id="";`
	`1280`	`+ id.clear();`
`1281`	`1281`	`}`
`1282`	`1282`	`else if(id_expr.id()==ID_template_function_instance)`
`1283`	`1283`	`{`
Original file line number	Diff line number	Diff line change
`@@ -129,7 +129,7 @@ int armcc_modet::doit()`
`129`	`129`	`}`
`130`	`130`	`else`
`131`	`131`	`{`
`132`		`- compiler.output_file_object="";`
	`132`	`+ compiler.output_file_object.clear();`
`133`	`133`	`compiler.output_file_executable="a.out";`
`134`	`134`	`}`
`135`	`135`
Original file line number	Diff line number	Diff line change
`@@ -94,7 +94,7 @@ int cw_modet::doit()`
`94`	`94`	`}`
`95`	`95`	`else`
`96`	`96`	`{`
`97`		`- compiler.output_file_object="";`
	`97`	`+ compiler.output_file_object.clear();`
`98`	`98`	`compiler.output_file_executable="a.out";`
`99`	`99`	`}`
`100`	`100`
Original file line number	Diff line number	Diff line change
`@@ -659,7 +659,7 @@ int gcc_modet::doit()`
`659`	`659`	`}`
`660`	`660`	`else`
`661`	`661`	`{`
`662`		`- compiler.output_file_object="";`
	`662`	`+ compiler.output_file_object.clear();`
`663`	`663`	`compiler.output_file_executable="a.out";`
`664`	`664`	`}`
`665`	`665`
`@@ -721,14 +721,14 @@ int gcc_modet::doit()`
`721`	`721`	`{`
`722`	`722`	`language=arg_it->arg;`
`723`	`723`	`if(language=="none")`
`724`		`- language="";`
	`724`	`+ language.clear();`
`725`	`725`	`}`
`726`	`726`	`}`
`727`	`727`	`else if(has_prefix(arg_it->arg, "-x"))`
`728`	`728`	`{`
`729`	`729`	`language=std::string(arg_it->arg, 2, std::string::npos);`
`730`	`730`	`if(language=="none")`
`731`		`- language="";`
	`731`	`+ language.clear();`
`732`	`732`	`}`
`733`	`733`	`}`
`734`	`734`	`}`
Original file line number	Diff line number	Diff line change
`@@ -123,7 +123,7 @@ int ld_modet::doit()`
`123`	`123`	`}`
`124`	`124`	`else`
`125`	`125`	`{`
`126`		`- compiler.output_file_object = "";`
	`126`	`+ compiler.output_file_object.clear();`
`127`	`127`	`compiler.output_file_executable = "a.out";`
`128`	`128`	`}`
`129`	`129`
Original file line number	Diff line number	Diff line change
`@@ -434,7 +434,7 @@ void ms_cl_cmdlinet::process_cl_option(const std::string &s)`
`434`	`434`	`if(s.size()==2)`
`435`	`435`	`{`
`436`	`436`	`option.islong=false;`
`437`		`- option.optstring="";`
	`437`	`+ option.optstring.clear();`
`438`	`438`	`option.optchar=s[1];`
`439`	`439`	`optnr=getoptnr(option.optchar);`
`440`	`440`	`}`
`@@ -470,7 +470,7 @@ void ms_cl_cmdlinet::process_cl_option(const std::string &s)`
`470`	`470`	`if(ms_cl_prefix.size()==1)`
`471`	`471`	`{`
`472`	`472`	`option.islong=false;`
`473`		`- option.optstring="";`
	`473`	`+ option.optstring.clear();`
`474`	`474`	`option.optchar=ms_cl_prefix[0];`
`475`	`475`	`optnr=getoptnr(option.optchar);`
`476`	`476`	`}`