Move check for bv size to flattening/ instead of ansi-c/

Author: NlightNFotis

regression/ansi-c/Issue_7104_Bv_Size/deref.desc

@@ -3,7 +3,7 @@ deref.c
 
 ^EXIT=1$
 ^SIGNAL=0$
-only bitvectors of size multiple of 8 can be dereferenced
+only bitvectors of size multiple of 8 bits can be dereferenced
 ^CONVERSION ERROR$
 --
 --

src/ansi-c/c_typecheck_expr.cpp

@@ -1805,17 +1805,6 @@ void c_typecheck_baset::typecheck_expr_dereference(exprt &expr)
       error() << "dereferencing void pointer" << eom;
       throw 0;
     }
-
-    if(is_signed_or_unsigned_bitvector(expr.type()))
-    {
-      auto bv_type_width = to_bitvector_type(expr.type()).get_width();
-      if(bv_type_width % 8 != 0)
-      {
-        throw invalid_source_file_exceptiont{
-          "only bitvectors of size multiple of 8 can be dereferenced",
-          expr.source_location()};
-      }
-    }
   }
   else
   {

src/solvers/flattening/boolbv_byte_extract.cpp

@@ -40,6 +40,12 @@ bvt boolbvt::convert_byte_extract(const byte_extract_exprt &expr)
   }
 
   const std::size_t width = boolbv_width(expr.type());
+  if(width % 8 != 0)
+  {
+    throw invalid_source_file_exceptiont{
+      "only bitvectors of size multiple of 8 bits can be dereferenced",
+      expr.source_location()};
+  }
 
   // special treatment for bit-fields and big-endian:
   // we need byte granularity