Use concretize instead of fill_in_array

This will allow to remove fill_in_array_expr which duplicates what
concretize does.

Author: romainbrenguier

src/solvers/refinement/string_refinement.cpp

@@ -2264,8 +2264,9 @@ exprt string_refinementt::get(const exprt &expr) const
       const exprt length = super_get(arr.length());
       if(const auto n = numeric_cast<std::size_t>(length))
       {
-        const array_exprt arr_model(array_typet(arr.type().subtype(), length));
-        return fill_in_array_expr(arr_model, generator.max_string_length);
+        const interval_sparse_arrayt sparse_array(
+          from_integer(CHARACTER_FOR_UNKNOWN, arr.type().subtype()));
+        return sparse_array.concretize(*n, length.type());
       }
     }
     return arr;

src/solvers/refinement/string_refinement_util.h

@@ -148,7 +148,7 @@ class interval_sparse_arrayt final : public sparse_arrayt
   /// Complexity is linear in the number of entries.
   exprt at(std::size_t index) const override;
 
-private:
+  /// Array containing the same value at each index.
   explicit interval_sparse_arrayt(exprt default_value)
     : sparse_arrayt(default_value)
   {