Use irep_idt() instead of ""

Constructing a dstringt from a C string requires a string table lookup, while
the default constructor for a dstringt just zero-initialises an unsigned.

Author: tautschnig

jbmc/src/java_bytecode/java_object_factory.cpp

@@ -290,9 +290,9 @@ void java_object_factoryt::gen_pointer_target_init(
   gen_nondet_init(
     assignments,
     init_expr,
-    false, // is_sub
-    "",    // class_identifier
-    false, // skip_classid
+    false,      // is_sub
+    irep_idt(), // class_identifier
+    false,      // skip_classid
     lifetime,
     {}, // no override type
     depth + 1,
@@ -757,9 +757,9 @@ symbol_exprt java_object_factoryt::gen_nondet_subtype_pointer_init(
   gen_nondet_init(
     assignments,
     new_symbol.symbol_expr(),
-    false, // is_sub
-    "",    // class_identifier
-    false, // skip_classid
+    false,      // is_sub
+    irep_idt(), // class_identifier
+    false,      // skip_classid
     lifetime,
     {}, // no override_type
     depth,
@@ -1546,9 +1546,9 @@ exprt object_factory(
   state.gen_nondet_init(
     assignments,
     object,
-    false, // is_sub
-    "",    // class_identifier
-    false, // skip_classid
+    false,      // is_sub
+    irep_idt(), // class_identifier
+    false,      // skip_classid
     lifetime,
     {}, // no override_type
     1,  // initial depth
@@ -1617,8 +1617,8 @@ void gen_nondet_init(
   state.gen_nondet_init(
     assignments,
     expr,
-    false, // is_sub
-    "",    // class_identifier
+    false,      // is_sub
+    irep_idt(), // class_identifier
     skip_classid,
     lifetime,
     {}, // no override_type

jbmc/src/java_bytecode/java_string_library_preprocess.cpp

@@ -42,7 +42,7 @@ static irep_idt get_tag(const typet &type)
   else if(type.id() == ID_struct)
     return irep_idt("java::" + id2string(to_struct_type(type).get_tag()));
   else
-    return "";
+    return irep_idt();
 }
 
 /// \param type: a type

src/analyses/ai.h

@@ -157,7 +157,7 @@ class ai_baset
     const goto_functionst::goto_functiont &goto_function,
     std::ostream &out) const
   {
-    output(ns, "", goto_function.body, out);
+    output(ns, irep_idt(), goto_function.body, out);
   }
 
   /// Output the abstract states for the whole program as JSON
@@ -178,15 +178,15 @@ class ai_baset
     const namespacet &ns,
     const goto_programt &goto_program) const
   {
-    return output_json(ns, "", goto_program);
+    return output_json(ns, irep_idt(), goto_program);
   }
 
   /// Output the abstract states for a single function as JSON
   jsont output_json(
     const namespacet &ns,
     const goto_functionst::goto_functiont &goto_function) const
   {
-    return output_json(ns, "", goto_function.body);
+    return output_json(ns, irep_idt(), goto_function.body);
   }
 
   /// Output the abstract states for the whole program as XML
@@ -207,15 +207,15 @@ class ai_baset
     const namespacet &ns,
     const goto_programt &goto_program) const
   {
-    return output_xml(ns, "", goto_program);
+    return output_xml(ns, irep_idt(), goto_program);
   }
 
   /// Output the abstract states for a single function as XML
   xmlt output_xml(
     const namespacet &ns,
     const goto_functionst::goto_functiont &goto_function) const
   {
-    return output_xml(ns, "", goto_function.body);
+    return output_xml(ns, irep_idt(), goto_function.body);
   }
 
 protected:

src/analyses/goto_rw.cpp

@@ -665,7 +665,7 @@ void guarded_range_domaint::output(
     out << itr->first << ":" << itr->second.first;
     // we don't know what mode (language) we are in, so we rely on the default
     // language to be reasonable for from_expr
-    out << " if " << from_expr(ns, "", itr->second.second);
+    out << " if " << from_expr(ns, irep_idt(), itr->second.second);
   }
   out << "]";
 }

src/analyses/invariant_set.cpp

@@ -137,7 +137,7 @@ std::string inv_object_storet::build_string(const exprt &expr) const
   // we don't know what mode (language) we are in, so we rely on the default
   // language to be reasonable for from_expr
   if(is_constant_address(expr))
-    return from_expr(ns, "", expr);
+    return from_expr(ns, irep_idt(), expr);
 
   if(expr.id()==ID_member)
   {
@@ -399,8 +399,8 @@ void invariant_sett::strengthen_rec(const exprt &expr)
     throw "non-Boolean argument to strengthen()";
 
   #if 0
-  std::cout << "S: " << from_expr(*ns, "", expr) << '\n';
-  #endif
+  std::cout << "S: " << from_expr(*ns, irep_idt(), expr) << '\n';
+#endif
 
   if(is_false)
   {
@@ -602,8 +602,8 @@ tvt invariant_sett::implies_rec(const exprt &expr) const
     throw "implies: non-Boolean expression";
 
   #if 0
-  std::cout << "I: " << from_expr(*ns, "", expr) << '\n';
-  #endif
+  std::cout << "I: " << from_expr(*ns, irep_idt(), expr) << '\n';
+#endif
 
   if(is_false) // can't get any stronger
     return tvt(true);

src/analyses/local_bitvector_analysis.cpp

@@ -349,7 +349,7 @@ void local_bitvector_analysist::output(
     }
 
     out << "\n";
-    goto_function.body.output_instruction(ns, "", out, *i_it);
+    goto_function.body.output_instruction(ns, irep_idt(), out, *i_it);
     out << "\n";
 
     l++;

src/analyses/local_may_alias.cpp

@@ -470,7 +470,7 @@ void local_may_aliast::output(
     }
 
     out << "\n";
-    goto_function.body.output_instruction(ns, "", out, *i_it);
+    goto_function.body.output_instruction(ns, irep_idt(), out, *i_it);
     out << "\n";
 
     l++;

src/analyses/local_safe_pointers.cpp

@@ -205,7 +205,7 @@ void local_safe_pointerst::output(
     }
 
     out << '\n';
-    goto_program.output_instruction(ns, "", out, *i_it);
+    goto_program.output_instruction(ns, irep_idt(), out, *i_it);
     out << '\n';
   }
 }
@@ -252,7 +252,7 @@ void local_safe_pointerst::output_safe_dereferences(
     }
 
     out << '\n';
-    goto_program.output_instruction(ns, "", out, *i_it);
+    goto_program.output_instruction(ns, irep_idt(), out, *i_it);
     out << '\n';
   }
 }

src/analyses/static_analysis.h

@@ -155,7 +155,7 @@ class static_analysis_baset
     const goto_programt &goto_program,
     std::ostream &out) const
   {
-    output(goto_program, "", out);
+    output(goto_program, irep_idt(), out);
   }
 
   virtual bool has_location(locationt l) const=0;

src/ansi-c/c_preprocess.cpp

@@ -199,9 +199,9 @@ static void error_parse_line(
     if(state==2)
     {
       saved_error_location.set_file(file);
-      saved_error_location.set_function("");
+      saved_error_location.set_function(irep_idt());
       saved_error_location.set_line(line_no);
-      saved_error_location.set_column("");
+      saved_error_location.set_column(irep_idt());
     }
   }