Avoid signed/unsigned casts and conversion in goto_inline

Author: tautschnig

src/goto-programs/goto_inline_class.cpp

@@ -16,6 +16,7 @@ Author: Daniel Kroening, [email protected]
 #endif
 
 #include <cassert>
+#include <limits>
 
 #include <util/base_type.h>
 #include <util/cprover_prefix.h>
@@ -700,7 +701,7 @@ bool goto_inlinet::check_inline_map(
   if(call_list.empty())
     return true;
 
-  int ln=-1;
+  unsigned ln = std::numeric_limits<unsigned>::max();
 
   for(const auto &call : call_list)
   {
@@ -713,8 +714,12 @@ bool goto_inlinet::check_inline_map(
     #endif
 
     // location numbers increasing
-    if(static_cast<int>(target->location_number)<=ln)
+    if(
+      ln < std::numeric_limits<unsigned>::max() &&
+      target->location_number <= ln)
+    {
       return false;
+    }
 
     if(!target->is_function_call())
       return false;