feat: First draft of flexible http outcalls #5890
Conversation
github-actions
bot
added
the
interface-spec
|
🤖 Here's your preview: https://hada6-4yaaa-aaaam-abaha-cai.icp0.io |
oggy-dfin
force-pushed
the
oggy/flexible-http-outcalls
branch
from
748a6ef to
b40ad06
Compare
| ic0.subnet_self_size : () -> I; // * | ||
| ic0.subnet_self_copy : (dst : I, offset : I, size : I) -> (); // * | ||
| ic0.subnet_self_node_count : () -> i32; // * |
There was a problem hiding this comment.
Bike-shedding question: Is it okay to use the terms "replica" and "node" interchangeably? I thought that we primarily use "replica" (but this PR favors the term "node").
Should we aim for consistency?
There was a problem hiding this comment.
We could also use the name "subnet_self_replication_factor". It is longer, but maybe better understandable that it links to cycles cost scaling (see https://internetcomputer.org/docs/building-apps/essentials/gas-cost#subnet-replication-factors).
There was a problem hiding this comment.
Actually I had replica originally, but even though (AFAICT) we don't have a precedent in the System API, I realized we used "node" in the state tree (e.g., /subnet/<subnet_id>/node/<node_id>/public_key) and in the management canister (e.g., node_metrics), so I went with "node" here
oggy-dfin
force-pushed
the
oggy/flexible-http-outcalls
branch
from
e14bba0 to
14a0954
Compare
oggy-dfin
changed the title
Co-authored-by: mraszyk <[email protected]>
Co-authored-by: mraszyk <[email protected]>
Co-authored-by: mraszyk <[email protected]>
docs/references/_attachments/ic.did
Outdated
| message: text; | ||
| }; | ||
|
|
||
| type flexible_http_request_result = record { |
There was a problem hiding this comment.
maybe I missed something. Shouldn't this be a variant? Or have we agreed to return the partial results (albeit shorter than min_responses) even though there were some errors?
There was a problem hiding this comment.
It should be a variant, sorry!
4 participants
Thank you for your contribution to the IC Developer Portal. This repo contains the content for https://internetcomputer.org and the ICP Developer Documentation, https://internetcomputer.org/docs/.
If you are submitting a pull request for adding or changing content on the ICP Developer Documentation, please make sure that your contribution meets the following requirements:
.mdxfile format to support the previous two components./sidebars.js, otherwise, it will not appear in theside navigation bar.
.github/CODEOWNERSfile iscontains any new directories or specific documents that you added that should be reviewed by a specific teamm.