fix for snapshot of MS SQL in 5.2

Author: Marcin Przepiorowski

CHANGELOG.md

@@ -1,3 +1,9 @@
+## 2.3.4.1
+
+### Changed
+
+* fix for MS SQL snapshot in 5.2
+
 ## 2.3.4
 
 ### Added

lib/MSSQLVDB_obj.pm

@@ -248,17 +248,44 @@ sub snapshot
     }
 
     my %snapshot_type;
+    
+    if ($self->{_dlpxObject}->getApi() lt "1.9") { 
 
-    if ($self->getType() eq 'VDB') {
-        %snapshot_type = (
-            "type" => "MSSqlSyncParameters"
-        );
-    }
-    else {
-        %snapshot_type = (
-            "type" => "MSSqlSyncParameters",
-            "loadFromBackup" => $frombackup_json
-        );
+      if ($self->getType() eq 'VDB') {
+          %snapshot_type = (
+              "type" => "MSSqlSyncParameters"
+          );
+      }
+      else {
+          %snapshot_type = (
+              "type" => "MSSqlSyncParameters",
+              "loadFromBackup" => $frombackup_json
+          );
+      }
+    
+    } else {
+
+      if ($self->getType() eq 'VDB') {
+          # it doesn't matter - but it has to be a valid option
+          # taken from GUI
+          %snapshot_type = (
+              "type" => "MSSqlNewCopyOnlyFullBackupSyncParameters",
+              "compressionEnabled" => JSON::false
+          );
+      }
+      else {
+          if ( $frombackup eq "yes" ) {
+            %snapshot_type = (
+                "type" => "MSSqlExistingMostRecentBackupSyncParameters"
+            );
+          } else {
+            %snapshot_type = (
+                "type" => "MSSqlNewCopyOnlyFullBackupSyncParameters",
+                "compressionEnabled" => JSON::false
+            );
+          }
+      }  
+      
     }
     return $self->VDB_obj::snapshot(\%snapshot_type) ;
 }

lib/Toolkit_helpers.pm

@@ -29,7 +29,7 @@ use File::Spec;
 
 use lib '../lib';
 
-our $version = '2.3.4';
+our $version = '2.3.4.1';
 
 sub logger {
 	my $debug = shift;