CE-340 Code changes to mask password in "ps" using expect utility #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Set theme jekyll-theme-minimal * add end of multi cluster * cbbackup exit code check * cbbackupmgr working with sudo, bucket list in snapshot in JSON * check mount points / doc updates * checks added, upgrade added * doc fixes * docs with multi node * fixing uid/gid regex * initial support for using non couchbase user through sudo * issue #22 - initial deployment, index support changes for backup ingestion, various fixes * new logo * partial work * proper style * resync of xdcr and backupmgr OK * v1.1.0 build 1.1.0.2 * v1.1.1 build 1.1.0.2 * ver 1.0.3.1 * ver 1.0.3.2 - sudo for all * version 1.0.2 * version 1.0.3 - error messages fix * version 1.1.0 build 0 * version 1.1.1 - added field for hostname * version 1.1.2 * workinf with copy config * working multinode * working with indexes - tested with backup only - ee, analytics removed from schema * xdcr fixed for multi IP, and different scenarios CE-59 Couchbase Plugin : Conversion of python2 to python3 (#38) Co-authored-by: Marcin Przepiorowski <[email protected]> Co-authored-by: ayesharustgi-delphix <[email protected]> DXE-683 Rename Select Connector - CouchBase DXE-988 Couchbase - VDB failed to enable (#36) Version 1.1.1 (#31) security fix draft
ayesharustgi-delphix
force-pushed
the
dlpx/pr/ayesharustgi-delphix/cab10d9a-e3bd-4424-9238-cc8f33cccb6b
branch
from
7d264cc to
1c232fa
Compare
ayesharustgi-delphix
requested review from
ankurtyagi-sdk,
manaskhandeshe-delphix and
prasad-in
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| # cmd = CommandFactory.xdcr_setup(cluster_name=self.parameters.stg_cluster_name, **env) | ||
| cmd, env_vars = CommandFactory.xdcr_setup_expect(cluster_name=self.parameters.stg_cluster_name, **env) | ||
| kwargs[ENV_VAR_KEY].update(env_vars) | ||
| stdout, stderr, exit_code = utilities.execute_expect(self.connection, cmd, **kwargs) |
Check notice
Code scanning / CodeQL
Unused local variable
| # cmd = CommandFactory.xdcr_setup(cluster_name=self.parameters.stg_cluster_name, **env) | ||
| cmd, env_vars = CommandFactory.xdcr_setup_expect(cluster_name=self.parameters.stg_cluster_name, **env) | ||
| kwargs[ENV_VAR_KEY].update(env_vars) | ||
| stdout, stderr, exit_code = utilities.execute_expect(self.connection, cmd, **kwargs) |
Check notice
Code scanning / CodeQL
Unused local variable
| # cmd = CommandFactory.xdcr_setup(cluster_name=self.parameters.stg_cluster_name, **env) | ||
| cmd, env_vars = CommandFactory.xdcr_setup_expect(cluster_name=self.parameters.stg_cluster_name, **env) | ||
| kwargs[ENV_VAR_KEY].update(env_vars) | ||
| stdout, stderr, exit_code = utilities.execute_expect(self.connection, cmd, **kwargs) |
Check notice
Code scanning / CodeQL
Unused local variable
prasad-in
approved these changes
May 26, 2023
ankurtyagi-sdk
approved these changes
May 26, 2023
| # print "get_dlpx_bin: ", CommandFactory.get_dlpx_bin(), "\n" | ||
| # | ||
| # print "unmount_file_system: ", CommandFactory.unmount_file_system(mount_path), "\n" | ||
| DLPX_BIN_JQ = "/var/tmp" |
Check notice
Code scanning / CodeQL
Unused global variable
ayesharustgi-delphix
deleted the
dlpx/pr/ayesharustgi-delphix/cab10d9a-e3bd-4424-9238-cc8f33cccb6b
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Provide a clear description of the high-level problem you are trying to
solve. The problem statement should be written in terms of a specific
symptom that affects users or the business. The problem statement should
not be written in terms of the solution. If possible, include a minimal
reproducible example (MRE) with steps to reproduce, expected results,
and actual results.
Solution
Provide a clear description of the high-level solution you have chosen.
If there were other possible solutions that you considered and rejected,
mention those along with the corresponding reasoning. Do not describe
implementation details when writing about the solution; these should go
into the implementation section instead.
Testing Done
Provide a clear description of how this change was tested. At minimum
this should include proof that a computer has executed the changed
lines. Ideally this should include an automated test or an explanation
as to why this pull request has no tests.