Skip to content

Commit 03e058e

Browse files
authored
test(vi): remove skip for VirtualImageCreation test (#1598)
Remove skip for VirtualImageCreation test. Signed-off-by: Daniil Loktev <[email protected]>
1 parent 2f2b347 commit 03e058e

File tree

1 file changed

+4
-16
lines changed

1 file changed

+4
-16
lines changed

test/e2e/legacy/images_creation.go

Lines changed: 4 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@ var _ = Describe("VirtualImageCreation", Ordered, func() {
3232
var (
3333
testCaseLabel = map[string]string{"testcase": "images-creation"}
3434
ns string
35-
criticalError error
3635
)
3736

3837
BeforeAll(func() {
@@ -75,12 +74,6 @@ var _ = Describe("VirtualImageCreation", Ordered, func() {
7574
}
7675
})
7776

78-
BeforeEach(func() {
79-
if criticalError != nil {
80-
Skip(fmt.Sprintf("Skip because blinking error: %s", criticalError.Error()))
81-
}
82-
})
83-
8477
Context("When resources are applied", func() {
8578
It("result should be succeeded", func() {
8679
res := kubectl.Apply(kc.ApplyOptions{
@@ -114,16 +107,11 @@ var _ = Describe("VirtualImageCreation", Ordered, func() {
114107
Context("When virtual images are applied", func() {
115108
It("checks VIs phases", func() {
116109
By(fmt.Sprintf("VIs should be in %s phases", v1alpha2.ImageReady))
117-
err := InterceptGomegaFailure(func() {
118-
WaitPhaseByLabel(kc.ResourceVI, string(v1alpha2.ImageReady), kc.WaitOptions{
119-
Labels: testCaseLabel,
120-
Namespace: ns,
121-
Timeout: MaxWaitTimeout,
122-
})
110+
WaitPhaseByLabel(kc.ResourceVI, string(v1alpha2.ImageReady), kc.WaitOptions{
111+
Labels: testCaseLabel,
112+
Namespace: ns,
113+
Timeout: MaxWaitTimeout,
123114
})
124-
if err != nil {
125-
criticalError = err
126-
}
127115
})
128116

129117
It("checks CVIs phases", func() {

0 commit comments

Comments
 (0)