Fix ylim of position plots #2
Merged
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a typo introduced in 354c3b4, where horizontal position ylim was overwritten by the vertical position ylim.
Owner
|
Sorry i didn't notice this earlier, thanks very much for contributing the fix! |
Author
|
No problem, happy to help! Thanks for merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a typo introduced in 354c3b4, where horizontal position ylim was overwritten by the vertical position ylim. This resulted in the vertical position plot taking the ylim of the horizontal position plot, and the vertical position plot automatically adjusting its ylim based on the data.
You can easily test and confirm this change on the Jupyter Notebook.