Skip to content

fix: return False for empty string in is_email() #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

RequiemBit
Copy link

  • Closes Bump cryptography from 2.8 to 3.2 #18
  • Empty string should not be considered a valid email.
  • Added explicit if input_string == "": return False guard in is_email().
  • Added unit test to prevent regression.
  • All existing tests still pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant