Skip to content

Conversation

@dimitri-yatsenko
Copy link
Member

@dimitri-yatsenko dimitri-yatsenko commented Sep 13, 2024

@dimitri-yatsenko dimitri-yatsenko changed the title Fix #1103 Fix #1103, #1057 Sep 14, 2024
@dimitri-yatsenko dimitri-yatsenko marked this pull request as draft September 14, 2024 02:39
@dimitri-yatsenko dimitri-yatsenko marked this pull request as ready for review September 14, 2024 03:48
@dimitri-yatsenko dimitri-yatsenko marked this pull request as draft September 14, 2024 14:44
@dimitri-yatsenko dimitri-yatsenko marked this pull request as ready for review September 16, 2024 00:04
@ethho
Copy link
Contributor

ethho commented Sep 16, 2024

@dimitri-yatsenko Do you want help writing pytests for topo_sort? Or should we just test manually for now?

@dimitri-yatsenko
Copy link
Member Author

topo_sort is already tested by multiple unit tests since it's used in several places. We can add more tests, of course.

Copy link
Contributor

@ethho ethho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes

@ethho ethho self-requested a review September 16, 2024 19:45
@ethho ethho merged commit 285605d into datajoint:master Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

.parts not always returning parts unite_master_parts breaks topological order of descendants and thus breaks cascading of table drops

2 participants