Fix issues seen during delta-rs integration #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yjshen
commented
Mar 23, 2023
| } | ||
|
|
||
| /// Write data into an open file. | ||
| pub fn write(&self, buf: &[u8]) -> Result<i32, HdfsErr> { |
Contributor
Author
There was a problem hiding this comment.
To align with the semantics of LocalFileSystem write, and imitate the behavior of https://doc.rust-lang.org/src/std/io/mod.rs.html#1540-1555, which actually allows an empty buffer as input, but writes the whole buffer out.
Collaborator
There was a problem hiding this comment.
As
Lines 1464 to 1466 in cadaee5
hdfsWrite won't write partial contents. Maybe it's better to refine the condition check as follows:if written_len >= 0 { Ok(written_len) } else { Err(HdfsErr::Generic(format!( "Fail to write contents to file {}", self.path() ))) }
Contributor
Author
There was a problem hiding this comment.
Reverted, only allow to call with an empty buffer and do nothing for this case.
|
|
||
| if ptr.is_null() { | ||
| Err(HdfsErr::Generic(format!( | ||
| Err(HdfsErr::FileNotFound(format!( |
| fn new_hdfs_file(&self, path: &str, file: hdfsFile) -> Result<HdfsFile, HdfsErr> { | ||
| if file.is_null() { | ||
| Err(HdfsErr::Generic(format!( | ||
| Err(HdfsErr::FileNotFound(format!( |
yahoNanJing
pushed a commit
that referenced
this pull request
Mar 27, 2023
* Fix issues seen during delta-rs integration * resolve coments: rm while * minimal changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.