From 50173dc55c1e21292a4fa8b6f453f1993110d76c Mon Sep 17 00:00:00 2001 From: Gary Roumanis Date: Mon, 22 Apr 2019 09:45:48 -0700 Subject: [PATCH 1/3] Move chrome profile to .dart_toosl --- webdev/lib/src/serve/chrome.dart | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/webdev/lib/src/serve/chrome.dart b/webdev/lib/src/serve/chrome.dart index 07af95e21..40ae5940d 100644 --- a/webdev/lib/src/serve/chrome.dart +++ b/webdev/lib/src/serve/chrome.dart @@ -6,6 +6,8 @@ import 'dart:async'; import 'dart:convert'; import 'dart:io'; +import 'package:path/path.dart' as p; + import 'package:webkit_inspection_protocol/webkit_inspection_protocol.dart'; import 'utils.dart'; @@ -62,7 +64,9 @@ class Chrome { /// /// Each url in [urls] will be loaded in a separate tab. static Future start(List urls, {int port}) async { - var dataDir = Directory.systemTemp.createTempSync(); + var dataDir = Directory.fromUri(Uri.parse(p.joinAll( + [Directory.current.path, '.dart_tool', 'webdev', 'chrome_profile']))) + ..createSync(recursive: true); port = port == null || port == 0 ? await findUnusedPort() : port; var args = [ // Using a tmp directory ensures that a new instance of chrome launches From 2395bf4936ca51c3a535129fa5f5e5befa82adff Mon Sep 17 00:00:00 2001 From: Gary Roumanis Date: Mon, 22 Apr 2019 09:47:46 -0700 Subject: [PATCH 2/3] format --- webdev/lib/src/serve/chrome.dart | 1 - 1 file changed, 1 deletion(-) diff --git a/webdev/lib/src/serve/chrome.dart b/webdev/lib/src/serve/chrome.dart index 40ae5940d..fb0357108 100644 --- a/webdev/lib/src/serve/chrome.dart +++ b/webdev/lib/src/serve/chrome.dart @@ -7,7 +7,6 @@ import 'dart:convert'; import 'dart:io'; import 'package:path/path.dart' as p; - import 'package:webkit_inspection_protocol/webkit_inspection_protocol.dart'; import 'utils.dart'; From 4d0513f34ed546a2d6267398ca0ce15513ebcca8 Mon Sep 17 00:00:00 2001 From: Gary Roumanis Date: Mon, 22 Apr 2019 10:24:05 -0700 Subject: [PATCH 3/3] fix weird call --- webdev/lib/src/serve/chrome.dart | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/webdev/lib/src/serve/chrome.dart b/webdev/lib/src/serve/chrome.dart index fb0357108..3e2dc21bf 100644 --- a/webdev/lib/src/serve/chrome.dart +++ b/webdev/lib/src/serve/chrome.dart @@ -63,8 +63,8 @@ class Chrome { /// /// Each url in [urls] will be loaded in a separate tab. static Future start(List urls, {int port}) async { - var dataDir = Directory.fromUri(Uri.parse(p.joinAll( - [Directory.current.path, '.dart_tool', 'webdev', 'chrome_profile']))) + var dataDir = Directory(p.joinAll( + [Directory.current.path, '.dart_tool', 'webdev', 'chrome_profile'])) ..createSync(recursive: true); port = port == null || port == 0 ? await findUnusedPort() : port; var args = [