From 26b2a30ba0ba4aa72997226cff94c4a4c08103a0 Mon Sep 17 00:00:00 2001 From: Jessy Yameogo Date: Mon, 24 Mar 2025 12:22:52 -0400 Subject: [PATCH] renamed DWDS injector parameter --- dwds/CHANGELOG.md | 4 +++- dwds/lib/dart_web_debug_service.dart | 4 ++-- dwds/lib/src/handlers/injector.dart | 10 +++++----- dwds/lib/src/version.dart | 2 +- dwds/pubspec.yaml | 2 +- 5 files changed, 12 insertions(+), 10 deletions(-) diff --git a/dwds/CHANGELOG.md b/dwds/CHANGELOG.md index aeca03c9e..b3f231017 100644 --- a/dwds/CHANGELOG.md +++ b/dwds/CHANGELOG.md @@ -1,4 +1,6 @@ -## 24.3.9-wip +## 24.3.9 + +- Renamed DWDS Injector parameter `enableDebuggingSupport` to `injectDebuggingSupportCode` for clearer intent. ## 24.3.8 diff --git a/dwds/lib/dart_web_debug_service.dart b/dwds/lib/dart_web_debug_service.dart index 9c219f830..83ed4be46 100644 --- a/dwds/lib/dart_web_debug_service.dart +++ b/dwds/lib/dart_web_debug_service.dart @@ -66,7 +66,7 @@ class Dwds { required Stream buildResults, required ConnectionProvider chromeConnection, required ToolConfiguration toolConfiguration, - bool enableDebuggingSupport = true, + bool injectDebuggingSupportCode = true, }) async { globalToolConfiguration = toolConfiguration; final debugSettings = toolConfiguration.debugSettings; @@ -120,7 +120,7 @@ class Dwds { final injected = DwdsInjector( extensionUri: extensionUri, - enableDebuggingSupport: enableDebuggingSupport, + injectDebuggingSupportCode: injectDebuggingSupportCode, ); final devHandler = DevHandler( diff --git a/dwds/lib/src/handlers/injector.dart b/dwds/lib/src/handlers/injector.dart index 3686c4f60..e4c263c88 100644 --- a/dwds/lib/src/handlers/injector.dart +++ b/dwds/lib/src/handlers/injector.dart @@ -30,7 +30,7 @@ const _clientScript = 'dwds/src/injected/client'; /// to include the injected DWDS client, enabling debugging capabilities /// and source mapping when running in a browser environment. /// -/// The `_enableDebuggingSupport` flag determines whether debugging-related +/// The `_injectDebuggingSupportCode` flag determines whether debugging-related /// functionality should be included: /// - When `true`, the DWDS client is injected, enabling debugging features. /// - When `false`, debugging support is disabled, meaning the application will @@ -42,13 +42,13 @@ class DwdsInjector { final Future? _extensionUri; final _devHandlerPaths = StreamController(); final _logger = Logger('DwdsInjector'); - final bool _enableDebuggingSupport; + final bool _injectDebuggingSupportCode; DwdsInjector({ Future? extensionUri, - bool enableDebuggingSupport = true, + bool injectDebuggingSupportCode = true, }) : _extensionUri = extensionUri, - _enableDebuggingSupport = enableDebuggingSupport; + _injectDebuggingSupportCode = injectDebuggingSupportCode; /// Returns the embedded dev handler paths. /// @@ -112,7 +112,7 @@ class DwdsInjector { ); // If true, inject the debugging client and hoist the main function // to enable debugging support. - if (_enableDebuggingSupport) { + if (_injectDebuggingSupportCode) { body = await _injectClientAndHoistMain( body, appId, diff --git a/dwds/lib/src/version.dart b/dwds/lib/src/version.dart index 81d8048d2..2294dc417 100644 --- a/dwds/lib/src/version.dart +++ b/dwds/lib/src/version.dart @@ -1,2 +1,2 @@ // Generated code. Do not modify. -const packageVersion = '24.3.9-wip'; +const packageVersion = '24.3.9'; diff --git a/dwds/pubspec.yaml b/dwds/pubspec.yaml index a8d827126..8e40fd0db 100644 --- a/dwds/pubspec.yaml +++ b/dwds/pubspec.yaml @@ -1,6 +1,6 @@ name: dwds # Every time this changes you need to run `dart run build_runner build`. -version: 24.3.9-wip +version: 24.3.9 description: >- A service that proxies between the Chrome debug protocol and the Dart VM service protocol.