Skip to content

Use 'compile js-dev' instead of invoking DDC directly #2579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 22, 2025
Merged

Use 'compile js-dev' instead of invoking DDC directly #2579

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
35bfa78
Use 'compile js-dev' instead of directly invoking the dartdevc snapshot.
a-siva Feb 21, 2025
6fdf399
Fix snapshot paths.
a-siva Feb 21, 2025
9609d09
Fix parameter.
a-siva Feb 21, 2025
d2e65fa
Use 'compile js-dev'
a-siva Feb 21, 2025
9130d89
Adjust sdk layout.
a-siva Feb 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions dwds/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
## 24.3.6-dev

- Bump minimum sdk version to 3.7.0
- use 'compile js-dev' instead of directly invoking the ddc snapshot.

## 24.3.5
- Allow clients to specify the `packageConfigPath` in `LoadStrategy` class and associated providers.
Expand Down
5 changes: 2 additions & 3 deletions dwds/test/expression_compiler_service_common.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,6 @@ void testAll({required CompilerOptions compilerOptions}) {
// generated in the SDK, so we use the current SDK layout and
// configuration.
final executable = Platform.resolvedExecutable;
final dartdevc =
SdkConfiguration.defaultConfiguration.compilerWorkerPath!;
// redirect logs for testing
_output = StreamController<String>.broadcast();
output.stream.listen(printOnFailure);
Expand Down Expand Up @@ -110,7 +108,8 @@ void testAll({required CompilerOptions compilerOptions}) {
''');

final args = [
dartdevc,
'compile',
'js-dev',
'try.dart',
'-o',
'try.js',
Expand Down
3 changes: 2 additions & 1 deletion frontend_server_client/example/web_client.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,8 @@ void main(List<String> args) async {

_print('compiling the dart sdk');
final sdkCompileResult = await Process.run(Platform.resolvedExecutable, [
p.join(sdkDir, 'bin', 'snapshots', 'dartdevc.dart.snapshot'),
'compile',
'js-dev',
'--multi-root-scheme=org-dartlang-sdk',
'--modules=amd',
'--module-name=dart_sdk',
Expand Down
3 changes: 2 additions & 1 deletion test_common/lib/sdk_asset_generator.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,8 @@ class SdkAssetGenerator {

final sdkDirectoryUri = fileSystem.directory(sdkLayout.sdkDirectory).uri;
final args = <String>[
sdkLayout.dartdevcSnapshotPath,
'compile',
'js-dev',
'--compile-sdk',
'--multi-root',
'$sdkDirectoryUri',
Expand Down
2 changes: 1 addition & 1 deletion test_common/lib/test_sdk_layout.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ class TestSdkLayout {
sdkLayout.sdkDirectory,
'bin',
'snapshots',
'kernel_worker.dart.snapshot',
'kernel_worker_aot.dart.snapshot',
),
devToolsDirectory: p.join(
sdkLayout.sdkDirectory,
Expand Down