From bf72af306fa96d1a1d5bf6e791e9e29bd66da56e Mon Sep 17 00:00:00 2001 From: Jessy Yameogo Date: Tue, 1 Oct 2024 13:20:14 -0400 Subject: [PATCH 1/4] replace deprecated __proto__ from js code --- dwds/lib/src/debugging/inspector.dart | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dwds/lib/src/debugging/inspector.dart b/dwds/lib/src/debugging/inspector.dart index 4bde89f75..524b53246 100644 --- a/dwds/lib/src/debugging/inspector.dart +++ b/dwds/lib/src/debugging/inspector.dart @@ -215,7 +215,7 @@ class AppInspector implements AppInspectorInterface { // We use the JS pseudo-variable 'arguments' to get the list of all arguments. final send = ''' function () { - if (!(this.__proto__)) { return 'Instance of PlainJavaScriptObject';} + if (!(Object.getPrototypeOf(this))) { return 'Instance of PlainJavaScriptObject';} return ${globalToolConfiguration.loadStrategy.loadModuleSnippet}("dart_sdk").dart.dsendRepl(this, "$methodName", arguments); } '''; From b86c2be9d362e46772c2981dd63a2afa85b1f6f2 Mon Sep 17 00:00:00 2001 From: Jessy Yameogo Date: Tue, 1 Oct 2024 13:52:12 -0400 Subject: [PATCH 2/4] updated changelog --- dwds/CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/dwds/CHANGELOG.md b/dwds/CHANGELOG.md index 52b5dbabe..5e97c81e0 100644 --- a/dwds/CHANGELOG.md +++ b/dwds/CHANGELOG.md @@ -1,4 +1,5 @@ ## 24.2.0-wip +- Replace deprecated JS code - [#2500](https://github.com/dart-lang/webdev/pull/2500) ## 24.1.0 From 87662d791daa740cdc72af774f47059a411d39e1 Mon Sep 17 00:00:00 2001 From: Jessy Yameogo Date: Tue, 1 Oct 2024 13:56:47 -0400 Subject: [PATCH 3/4] Update dwds/lib/src/debugging/inspector.dart Co-authored-by: Derek Xu --- dwds/lib/src/debugging/inspector.dart | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dwds/lib/src/debugging/inspector.dart b/dwds/lib/src/debugging/inspector.dart index 524b53246..c13dcf27d 100644 --- a/dwds/lib/src/debugging/inspector.dart +++ b/dwds/lib/src/debugging/inspector.dart @@ -215,7 +215,7 @@ class AppInspector implements AppInspectorInterface { // We use the JS pseudo-variable 'arguments' to get the list of all arguments. final send = ''' function () { - if (!(Object.getPrototypeOf(this))) { return 'Instance of PlainJavaScriptObject';} + if (!Object.getPrototypeOf(this)) { return 'Instance of PlainJavaScriptObject';} return ${globalToolConfiguration.loadStrategy.loadModuleSnippet}("dart_sdk").dart.dsendRepl(this, "$methodName", arguments); } '''; From ec72979f227beeee20c6c9ed61820004aa756a40 Mon Sep 17 00:00:00 2001 From: Jessy Yameogo Date: Tue, 1 Oct 2024 13:57:13 -0400 Subject: [PATCH 4/4] Update dwds/CHANGELOG.md Co-authored-by: Derek Xu --- dwds/CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dwds/CHANGELOG.md b/dwds/CHANGELOG.md index 5e97c81e0..95cd526b0 100644 --- a/dwds/CHANGELOG.md +++ b/dwds/CHANGELOG.md @@ -1,5 +1,5 @@ ## 24.2.0-wip -- Replace deprecated JS code - [#2500](https://github.com/dart-lang/webdev/pull/2500) +- Replace deprecated JS code `this.__proto__` with `Object.getPrototypeOf(this)` - [#2500](https://github.com/dart-lang/webdev/pull/2500) ## 24.1.0