From d9ede5262b1cbb632ab339f819e5e4325ce835e1 Mon Sep 17 00:00:00 2001 From: Paul Berry Date: Mon, 26 Aug 2024 18:33:39 +0000 Subject: [PATCH 1/2] [dwds] Delete unreachable `default` clauses. The Dart analyzer will soon be changed so that if the `default` clause of a `switch` statement is determined to be unreachable by the exhaustiveness checker, a new warning of type `unreachable_switch_default` will be issued. This parallels the behavior of the existing `unreachable_switch_case` warning, which is issued whenever a `case` clause of a `switch` statement is determined to be unreachable. For details see https://github.com/dart-lang/sdk/issues/54575. This PR deletes unreachable `default` clauses from `webdev/dwds` now, to avoid a spurious warning when the analyzer change lands. --- dwds/lib/src/debugging/instance.dart | 1 - dwds/lib/src/servers/extension_debugger.dart | 2 -- 2 files changed, 3 deletions(-) diff --git a/dwds/lib/src/debugging/instance.dart b/dwds/lib/src/debugging/instance.dart index bc6f5f3a4..c69560079 100644 --- a/dwds/lib/src/debugging/instance.dart +++ b/dwds/lib/src/debugging/instance.dart @@ -170,7 +170,6 @@ class InstanceHelper extends Domain { case RuntimeObjectKind.object: case RuntimeObjectKind.nativeError: case RuntimeObjectKind.nativeObject: - default: return await _plainInstanceFor( metaData, remoteObject, diff --git a/dwds/lib/src/servers/extension_debugger.dart b/dwds/lib/src/servers/extension_debugger.dart index 6c0736198..a7a2fa999 100644 --- a/dwds/lib/src/servers/extension_debugger.dart +++ b/dwds/lib/src/servers/extension_debugger.dart @@ -364,8 +364,6 @@ class ExtensionDebugger implements RemoteDebugger { return 'none'; case PauseState.uncaught: return 'uncaught'; - default: - throw ArgumentError('unknown state: $state'); } } From 2c8f6c38e1d0e47a609732c7275ce8c4d6fad31d Mon Sep 17 00:00:00 2001 From: Paul Berry Date: Tue, 27 Aug 2024 10:50:02 +0000 Subject: [PATCH 2/2] Reformat `dwds/lib/src/debugging/instance.dart` --- dwds/lib/src/debugging/instance.dart | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/dwds/lib/src/debugging/instance.dart b/dwds/lib/src/debugging/instance.dart index c69560079..3d750e671 100644 --- a/dwds/lib/src/debugging/instance.dart +++ b/dwds/lib/src/debugging/instance.dart @@ -267,9 +267,8 @@ class InstanceHelper extends Domain { objectId, offset: offset, count: count, - length: metaData.kind != InstanceKind.kPlainInstance - ? metaData.length - : null, + length: + metaData.kind != InstanceKind.kPlainInstance ? metaData.length : null, ); final dartProperties = await _dartFieldsFor(properties, remoteObject);