From 1b6747c9f51569bec8275cf2831af502a39ee445 Mon Sep 17 00:00:00 2001 From: Elliott Brooks <21270878+elliette@users.noreply.github.com> Date: Tue, 16 Jan 2024 16:46:15 -0800 Subject: [PATCH 1/2] Cider connection --- dwds/debug_extension_mv3/web/cider_connection.dart | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/dwds/debug_extension_mv3/web/cider_connection.dart b/dwds/debug_extension_mv3/web/cider_connection.dart index 8dbda4b4a..6dcdf86b0 100644 --- a/dwds/debug_extension_mv3/web/cider_connection.dart +++ b/dwds/debug_extension_mv3/web/cider_connection.dart @@ -30,6 +30,8 @@ enum CiderMessageType { error, inspectorUrlResponse, inspectorUrlRequest, + ping, + pong, startDebugResponse, startDebugRequest, stopDebugResponse, @@ -103,6 +105,7 @@ void _sendMessageToCider(String json) { } Future _handleMessageFromCider(dynamic message, Port _) async { + debugLog('Received message from Cider $message'); final key = getProperty(message, 'key'); final json = getProperty(message, 'json'); if (key != _ciderDartMessageKey || json is! String) { @@ -117,12 +120,17 @@ Future _handleMessageFromCider(dynamic message, Port _) async { final messageType = decoded['messageType'] as String?; final messageBody = decoded['messageBody'] as String?; + debugLog('Message type is $messageType'); + if (messageType == CiderMessageType.startDebugRequest.name) { await _startDebugging(appId: messageBody); } else if (messageType == CiderMessageType.stopDebugRequest.name) { await _stopDebugging(appId: messageBody); } else if (messageType == CiderMessageType.inspectorUrlRequest.name) { await _sendInspectorUrl(appId: messageBody); + } else if (messageType == CiderMessageType.ping.name) { + debugLog('Sending back PONG!'); + sendMessageToCider(messageType: CiderMessageType.pong); } } From c5a7845e39479bb01503edc7a54760b18635e670 Mon Sep 17 00:00:00 2001 From: Elliott Brooks <21270878+elliette@users.noreply.github.com> Date: Tue, 16 Jan 2024 16:47:36 -0800 Subject: [PATCH 2/2] Remove log messages --- dwds/debug_extension_mv3/web/cider_connection.dart | 4 ---- 1 file changed, 4 deletions(-) diff --git a/dwds/debug_extension_mv3/web/cider_connection.dart b/dwds/debug_extension_mv3/web/cider_connection.dart index 6dcdf86b0..666e283d5 100644 --- a/dwds/debug_extension_mv3/web/cider_connection.dart +++ b/dwds/debug_extension_mv3/web/cider_connection.dart @@ -105,7 +105,6 @@ void _sendMessageToCider(String json) { } Future _handleMessageFromCider(dynamic message, Port _) async { - debugLog('Received message from Cider $message'); final key = getProperty(message, 'key'); final json = getProperty(message, 'json'); if (key != _ciderDartMessageKey || json is! String) { @@ -120,8 +119,6 @@ Future _handleMessageFromCider(dynamic message, Port _) async { final messageType = decoded['messageType'] as String?; final messageBody = decoded['messageBody'] as String?; - debugLog('Message type is $messageType'); - if (messageType == CiderMessageType.startDebugRequest.name) { await _startDebugging(appId: messageBody); } else if (messageType == CiderMessageType.stopDebugRequest.name) { @@ -129,7 +126,6 @@ Future _handleMessageFromCider(dynamic message, Port _) async { } else if (messageType == CiderMessageType.inspectorUrlRequest.name) { await _sendInspectorUrl(appId: messageBody); } else if (messageType == CiderMessageType.ping.name) { - debugLog('Sending back PONG!'); sendMessageToCider(messageType: CiderMessageType.pong); } }