From 2e9ebee00a54ebafd5528fd7ac906bdaea8ff3ed Mon Sep 17 00:00:00 2001 From: Elliott Brooks <21270878+elliette@users.noreply.github.com> Date: Tue, 19 Sep 2023 16:57:11 -0700 Subject: [PATCH 1/4] Update interface --- dwds/lib/src/services/chrome_proxy_service.dart | 3 +++ 1 file changed, 3 insertions(+) diff --git a/dwds/lib/src/services/chrome_proxy_service.dart b/dwds/lib/src/services/chrome_proxy_service.dart index 422d1bcf6..aad2b6e1a 100644 --- a/dwds/lib/src/services/chrome_proxy_service.dart +++ b/dwds/lib/src/services/chrome_proxy_service.dart @@ -803,6 +803,9 @@ ${globalLoadStrategy.loadModuleSnippet}("dart_sdk").developer.invokeExtension( bool? forceCompile, bool? reportLines, List? libraryFilters, + // Note: Ignore the optional librariesAlreadyCompiled parameter. It is here + // to match the VM service interface. + bool? librariesAlreadyCompiled, }) => wrapInErrorHandlerAsync( 'getSourceReport', From 5925f268936580152dff18f92149cf644ee5e394 Mon Sep 17 00:00:00 2001 From: Elliott Brooks <21270878+elliette@users.noreply.github.com> Date: Tue, 19 Sep 2023 16:59:51 -0700 Subject: [PATCH 2/4] Update CHANGELOG --- dwds/CHANGELOG.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/dwds/CHANGELOG.md b/dwds/CHANGELOG.md index 9e71edb21..74ffb83eb 100644 --- a/dwds/CHANGELOG.md +++ b/dwds/CHANGELOG.md @@ -1,5 +1,7 @@ ## 21.1.0-wip +- Update the interface for ChromeProxyService.getSourceReport to match the VM service. - [#2235](https://github.com/dart-lang/webdev/pull/2235) + ## 21.0.0 - Update Dart SDK constraint to `>=3.2.0-36.0.dev <4.0.0`. - [#2207](https://github.com/dart-lang/webdev/pull/2207) @@ -17,7 +19,7 @@ - Require clients to specify the `basePath` on `AssetReader`. - [#2160](https://github.com/dart-lang/webdev/pull/2160) - Update SDK constraint to `>=3.1.0-254.0.dev <4.0.0`. - [#2169](https://github.com/dart-lang/webdev/pull/2169) -- Require min `build_web_compilers` version `4.0.4` - [#2171](https://github.com/dart-lang/webdev/pull/2171) +- Require min `build_web_compilers` version `4.0.4` - [#2171](https://github.com/dart-lang/webdev/pul l/2171) - Switch to using new debugging API from DDC to support new type system. - [#2159](https://github.com/dart-lang/webdev/pull/2159) - Fix Flutter crash when calling `resume` when app is not paused. - [#2188](https://github.com/dart-lang/webdev/pull/2188) - Update file dependency to `7.0.0`. From c8e2ca7be2227d1682e96c884f788271ab37d6b2 Mon Sep 17 00:00:00 2001 From: Elliott Brooks <21270878+elliette@users.noreply.github.com> Date: Tue, 19 Sep 2023 17:00:39 -0700 Subject: [PATCH 3/4] Remove accidental edit --- dwds/CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dwds/CHANGELOG.md b/dwds/CHANGELOG.md index 74ffb83eb..025cbdaa3 100644 --- a/dwds/CHANGELOG.md +++ b/dwds/CHANGELOG.md @@ -19,7 +19,7 @@ - Require clients to specify the `basePath` on `AssetReader`. - [#2160](https://github.com/dart-lang/webdev/pull/2160) - Update SDK constraint to `>=3.1.0-254.0.dev <4.0.0`. - [#2169](https://github.com/dart-lang/webdev/pull/2169) -- Require min `build_web_compilers` version `4.0.4` - [#2171](https://github.com/dart-lang/webdev/pul l/2171) +- Require min `build_web_compilers` version `4.0.4` - [#2171](https://github.com/dart-lang/webdev/pull/2171) - Switch to using new debugging API from DDC to support new type system. - [#2159](https://github.com/dart-lang/webdev/pull/2159) - Fix Flutter crash when calling `resume` when app is not paused. - [#2188](https://github.com/dart-lang/webdev/pull/2188) - Update file dependency to `7.0.0`. From 87af30c6f0944101e801dd13689bef2d99830259 Mon Sep 17 00:00:00 2001 From: Elliott Brooks <21270878+elliette@users.noreply.github.com> Date: Tue, 19 Sep 2023 17:07:08 -0700 Subject: [PATCH 4/4] wrong type --- dwds/lib/src/services/chrome_proxy_service.dart | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dwds/lib/src/services/chrome_proxy_service.dart b/dwds/lib/src/services/chrome_proxy_service.dart index aad2b6e1a..44b4bfea4 100644 --- a/dwds/lib/src/services/chrome_proxy_service.dart +++ b/dwds/lib/src/services/chrome_proxy_service.dart @@ -805,7 +805,7 @@ ${globalLoadStrategy.loadModuleSnippet}("dart_sdk").developer.invokeExtension( List? libraryFilters, // Note: Ignore the optional librariesAlreadyCompiled parameter. It is here // to match the VM service interface. - bool? librariesAlreadyCompiled, + List? librariesAlreadyCompiled, }) => wrapInErrorHandlerAsync( 'getSourceReport',